Changed CorrPCCProducer from EDProducer to DQMEDAnalyzer for LumiPOG

[samhiggie]

We've changed the CorrPCCProducer from an EDProducer to a DQMEDAnalyzer so that we can extract histograms for systematics.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22868/4253

[cmsbuild]

A new Pull Request was created by @samhiggie for master.

It involves the following packages:

Calibration/LumiAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Changed CorrPCCProducer from EDProducer to DQMEDAnalyzer for LumiPOG #22868

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27325/console Started: 2018/04/05 21:49

[arunhep]

@samhiggie can you also make a backport to 10.1.X ? We will then add that to the list of things needed for 10.1.1 release

[samhiggie]

@arunhep Yes, I can start the backport. I should mention, that I started this PR with 10.1.0.pre3, so it should be quick. Thanks.

[cmsbuild]

+1
Tested at: 5af58c6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22868/27325/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22868/27325/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2498516
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2498339
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.21 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[arunhep]

@fabiocos this looks strange to me. i see the tests passed and comparisons available but it says RelVals Error as well.

[fabiocos]

@arunhep sorry, where do you see relval errors? I see everything clean, what am I missing?

[samhiggie]

Does anyone have good documentation on how to test the DQM analyzer? It would be very beneficial if I could have a simple configuration file detailing how to organize the output etc...
While I'm at it, there are new type_2 parameters that we would like to incorporate. I have these configurable with the file I am using to generate the DQM output. We would like these new ones at PCL as well. Should I do that all here or try to request a PR to @cerminar ?

[capalmer85]

Can someone please "please test"?

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27641/console Started: 2018/04/25 10:39

[cmsbuild]

+1
Tested at: 3f44e51
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22868/27641/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22868/27641/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2494144
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2493967
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[kpedro88]

+1

[fabozzi]

+1

[kpedro88]

backport of #22868

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1