Remove check for empty sum collection in CALOL2-uGT comparison

[ashtipliyski]

PR addresses a false alarm that the DQM comparison plot located under

L1T / L1TStage2uGT / calol2ouput_vs_uGTinput / errorSummaryNum

where the plot will report an error in the reconstructed energy sums when no calorimeters are included in the run. In such circumstances the error is meaningless since there are no inputs to the calorimeter trigger. The changes remove the check that both CALOL2 and uGT sum collections are not empty but leaves the check that the length of those should not be different.

10_1_x backport is here #22883
10_0_x backport is here #22884

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22878/4260

[cmsbuild]

A new Pull Request was created by @ashtipliyski (Antoni Shtipliyski) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

Please adapt also the comment to the new code.

[ashtipliyski]

Thanks for pointing this out Thomas, I modified to reflect the code and updated the PR.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22878/4261

[cmsbuild]

Pull request #22878 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27347/console Started: 2018/04/06 16:02

[cmsbuild]

-1

Tested at: 4227700

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22878/27347/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Fri Apr 6 17:41:12 2018-date Fri Apr 6 17:36:59 2018 s - exit: 16640

[cmsbuild]

Comparison job queued.

[cmsbuild]

+1
Tested at: 4227700
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22878/27355/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22878/27355/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504254
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2504077
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.06000000014 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@ashtipliyski is this PR supposed to produce effect on some test plot? No difference is observed in the tests

[fabiocos]

+1

[apana]

@ashtipliyski Actually, I think some workflows need the check for the empty sum collection. I know because I was crashing the uGT emulator in runTheMatrix workflow 134.813. Once I fixed my problem the workflow crashed in your code. The reason is workflow 134.813 runs the Stage2 emulator and DQM on Cosmics data from Run1. In this workflow, the unpacked collections will have zero length and the code if it tries to access the member data. (the uGT emulator was crashing this workflow for the same reason).

If you like, I can revert this change in my PR.

-Len

[fabiocos]

@ashtipliyski @apana dear all, it would be good to avoid moving the problem from one place to another. If you consider that with the fix for the crash in 134.813 this PR will become unsafe, please just revert it in your code

[apana]

Hi @fabiocos. Yeah, sorry about that. I should have either put in the fix, or waited until @ashtipliyski was able to respond. Bad choice on my part. I have now updated my branch with the fix.

[thomreis]

Hi @fabiocos @apana
we have removed the checking for empty et sum collections because it gives mismatch errors in the DQM if calo l2 is not in the run. So we would like to keep these changes.
It is not clear to me how this change can cause a wf to crash since it only fills a histogram in the DQM in fewer cases.