CTPPS Pixel DQM: protection against RP ID corruption

[popovvp]

No description provided.

[cmsbuild]

@popovvp, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22889/4271

[cmsbuild]

A new Pull Request was created by @popovvp for master.

It involves the following packages:

DQM/CTPPS

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27376/console Started: 2018/04/07 17:37

[cmsbuild]

+1
Tested at: f7f8703
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22889/27376/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22889/27376/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504254
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2504077
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.980000000098 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22889/4284

[cmsbuild]

Pull request #22889 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27390/console Started: 2018/04/09 09:38

[cmsbuild]

+1
Tested at: 93c377e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22889/27390/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22889/27390/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504254
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2504077
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.700000000004 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@popovvp where is the effect of this fix supposed to be seen? Could you please explain the problem?
I understand that the status arrays were incorrectly sized.

[popovvp]

status array's size were set correctly as we can have only 6 RP. But length of RP number is 3 bits, so in case of data corruption incorrect number 7 and 8 can be produced.

[fabiocos]

@popovvp ok, thanks, I understand that this protection is sufficient for the problems observed so far

[fabiocos]

+1