SLHC Digi validation fix

[abdoulline]

Minor fix in SLHC Digi validation to properly fill signal fraction histos

[cmsbuild]

A new Pull Request was created by @abdoulline for CMSSW_6_2_X_SLHC.

SLHC Digi validation fix

It involves the following packages:

Validation/HcalDigis

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
3400 step4

runTheMatrix-results/3400_FourMuPt1_200+FourMuPt1_200_UPG2019+DIGIUP19+RECOUP19+HARVESTUP19/step4_FourMuPt1_200+FourMuPt1_200_UPG2019+DIGIUP19+RECOUP19+HARVESTUP19.log
----- Begin Fatal Exception 05-Feb-2014 12:05:51 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmHarvesting'
   [2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Requested conditions of type HcalPedestals for cell (0x42006101) (HB 2,1,1) got conditions for cell (0x4200608d) (HB 1,13,1)
----- End Fatal Exception -------------------------------------------------

15001 step4

runTheMatrix-results/15001_FourMuPt1_200+FourMuPt1_200_UPG2019_300+DIGIUP19300+RECOUP19300+HARVESTUP19300/step4_FourMuPt1_200+FourMuPt1_200_UPG2019_300+DIGIUP19300+RECOUP19300+HARVESTUP19300.log
----- Begin Fatal Exception 05-Feb-2014 12:05:59 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmHarvesting'
   [2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Requested conditions of type HcalPedestals for cell (0x42006101) (HB 2,1,1) got conditions for cell (0x4200608d) (HB 1,13,1)
----- End Fatal Exception -------------------------------------------------

50001 step1

runTheMatrix-results/50001_TTbar_14TeV+TTbarFSP2+HARVESTFSP2/step1_TTbar_14TeV+TTbarFSP2+HARVESTFSP2.log

60001 step1

runTheMatrix-results/60001_TTbar_14TeV+TTbarFSP2Forw+HARVESTFSP2Forw/step1_TTbar_14TeV+TTbarFSP2Forw+HARVESTFSP2Forw.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2301/18/summary.html

[mark-grimes]

@cmsbuild these are known errors in CMSSW_6_2_X before this pull request is applied.

The error in 3400 and 15001 is because runTheMatrix doesn't use the correct customisation command for step 4. If the cmsDriver command for step 4 is executed by hand with the correct customisation (as runTheMatrix uses for steps 1-3) both these tests should run fine. This was introduced by #2265 (the incorrect customisation producing an error - the incorrect customisation has been there for a while) and will hopefully be fixed soon.

The segmentation fault in 50001 and 60001 was introduced by a small change in #2236. These tests are for FastSim for two of the phase 2 geometries - it is unlikely FastSim for these worked beforehand but it just didn't produce a crash. It was discussed in yesterdays ORP meeting and decided to put this pull request in because the pull request is needed for FullSim performance and we currently don't use FastSim workflows.

[mark-grimes]

merge

Tested again after fixing tests 3400 and 15001 with #2468. All tests (including 3400 with combinedCustoms.cust_2019WithGem) pass except for 50001 and 60001 which is the known problem. I'm going to stop running those tests for the rest of these pull requests.