Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify upgrade digi collections for HCAL TP emulation in offline DQM #23040

Conversation

christopheralanwest
Copy link
Contributor

Backport #23039

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2018

A new Pull Request was created by @christopheralanwest for CMSSW_10_1_X.

It involves the following packages:

L1Trigger/Configuration

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27618/console Started: 2018/04/23 18:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23040/27618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506125
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.328 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 0.011 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 136.788 ): 0.011 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 136.788 ): 0.011 KiB RecoTauV/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.010 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.009 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.008 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.007 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.007 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.007 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 136.788,... ): 0.007 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 21234.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Apr 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f45c9c6 into cms-sw:CMSSW_10_1_X May 11, 2018
@christopheralanwest christopheralanwest deleted the hcal-tp-emul-inputUpgradeLabel-10_1_2_patch2 branch August 21, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants