Add flag to configure production of DDU-based trigger synch plots [10_2_X]

[battibass]

This PR is intended to fix the T0 issue related to pathALCARECODtCalib reported in this HN thread.

What it does is making the production of a few plots (hence the access to some products) configurable and disables them in the 2018 era.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23071/4478

[cmsbuild]

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

DQM/DTMonitorModule

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27673/console Started: 2018/04/26 19:33

[fabiocos]

@battibass from your private communication I understand that this PR (actually its 10_1_X back-port) has been verified to solve one of the crash reported:

On 26 Apr 2018, at 18:22, Carlo Battilana Carlo.Battilana@cern.ch wrote:

Dear All,
please find in [1] and [2] two PRs aimed at fixing the issue reported in this thread.
[1] has been tested using the tarball in [3] to confirm that the error disappears.

Please note that it is not possible to fix the crash with a simple configuration change, as the collection that was used as input is not produced anymore (the workflow also looks at local trigger primitives produced with a different format, that keep being produced).

We apologise for the issue that got unnoticed during the transition to the uROS unpacker.

Best,

Carlo for DT

[1] #23072
[2] #23071
[3] /store/unmerged/express/logs/prod/2018/4/25/Express_Run315104_StreamExpress/Express/0000/3/Express-008f0a70-c1f2-417b-b694-2f3f6a7884d9-3-logArchive.tar.gz

[battibass]

Correct, after the fix I see:

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 315104 lumi: 93 event: 34403445 stream: 2
   [1] Running path 'pathALCARECODtCalib'
   [2] Calling method for module DTLocalTriggerSynchTask/'dtTriggerSynchMonitor'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<DTChamberId,DTLocalTrigger>
Looking for module label: muonDTDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

disappearing and the job completes just fine.

[cmsbuild]

-1

Tested at: 3a0e1c0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23071/27673/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Apr 26 21:13:10 2018-date Thu Apr 26 21:07:26 2018 s - exit: 35584

[cmsbuild]

Comparison job queued.

[jfernan2]

the crash from AddOn seems unrelated, I launch the test again
please test

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27676/console Started: 2018/04/26 22:04

[fabiocos]

@jfernan2 the crash is in fastsim and has nothing to do with this PR, and it does not look reproducible when running a standalone cross check

[cmsbuild]

+1
Tested at: 3a0e1c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23071/27676/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23071/27676/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2495054
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2494877
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

@dmitrijus @jfernan2 could you please check and sign it in case? I would like to get it in asap and build pre2

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1