New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to configure production of DDU-based trigger synch plots [10_1_X] #23072
Add flag to configure production of DDU-based trigger synch plots [10_1_X] #23072
Conversation
A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_10_1_X. It involves the following packages: DQM/DTMonitorModule @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -27,4 +28,8 @@ | |||
tTrigMode = cms.string('DTTTrigSyncFromDB') | |||
) | |||
|
|||
from Configuration.Eras.Modifier_run2_DT_2018_cff import run2_DT_2018 | |||
run2_DT_2018.toModify(dtTriggerSynchMonitor,processDDU = cms.bool(False)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be simply processDDU = False
type specs are not needed
https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1875/1/1.html
@battibass sorry, but was the full PR tested, as discussed in the master version? Probably not the part of the python configuration. I see that Slava has requested for 2018 test workflows in the matrix, I think it would be good to have some T0 like workflows where these kind of things can be looked at without waiting for a replay |
@fabiocos apologies, it was tested using the tarball referring to the job crash. Indeed that tarball includes all the configuration and ignores the python snippet ... |
This PR is a backport of PR23071, intended to fix the T0 issue related to pathALCARECODtCalib reported in this HN thread.
What it does is making the production of a few plots (hence the access to some products) configurable and disables them in the 2018 era.