Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to configure production of DDU-based trigger synch plots [10_1_X] #23072

Merged
merged 2 commits into from Apr 27, 2018

Conversation

battibass
Copy link

This PR is a backport of PR23071, intended to fix the T0 issue related to pathALCARECODtCalib reported in this HN thread.

What it does is making the production of a few plots (hence the access to some products) configurable and disables them in the 2018 era.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_10_1_X.

It involves the following packages:

DQM/DTMonitorModule

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27672/console Started: 2018/04/26 19:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23072/27672/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506154
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.025 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 1306.0 ): 0.007 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.006 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1306.0 ): 0.004 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.002 KiB RecoTauV/EventInfo
  • DQMHistoSizes: changed ( 1306.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0295353 into cms-sw:CMSSW_10_1_X Apr 27, 2018
@@ -27,4 +28,8 @@
tTrigMode = cms.string('DTTTrigSyncFromDB')
)

from Configuration.Eras.Modifier_run2_DT_2018_cff import run2_DT_2018
run2_DT_2018.toModify(dtTriggerSynchMonitor,processDDU = cms.bool(False))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be simply processDDU = False
type specs are not needed
https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1875/1/1.html

@fabiocos
Copy link
Contributor

fabiocos commented May 4, 2018

@battibass sorry, but was the full PR tested, as discussed in the master version? Probably not the part of the python configuration. I see that Slava has requested for 2018 test workflows in the matrix, I think it would be good to have some T0 like workflows where these kind of things can be looked at without waiting for a replay

@battibass
Copy link
Author

@fabiocos apologies, it was tested using the tarball referring to the job crash. Indeed that tarball includes all the configuration and ignores the python snippet ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants