L1T DQM Retire unneeded caloLayer2 data-emulator ratio plots

[thomreis]

The caloLayer2 data over emulator ratio plots are not needed anymore since there re now dedicated event by event comparison plots for the data vs. emulator agreement checks.

The running of the caloLayer2 DQM module in the emulator client also results in a race condition in the DQMGUI where the histograms produced by the l1tstage2 client race against the ones from the l1tstage2emulator client. Since the later have much less events as they only run in fat events, only the ones from the l1tstage2 client are desired. With the removal of the ratio plots the l1tstage2emulator version of the histograms are not needed anymore and could be removed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23096/4510

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27714/console Started: 2018/04/30 11:27

[cmsbuild]

+1
Tested at: 2b6187c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23096/27714/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23096/27714/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2495096
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2494919
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@thomreis this PR is supposed to remove histograms, but no change in DQM memory content is observed. Could you please clarify?

[jfernan2]

@fabiocos This PR, as many others from DQM where we have a PR for master and a corresponding backport, is only modifying Online DQM. Hence DQM HistoTests on offline/relval samples are not sensible to this kind of changes
I will write you a separate email about how to deal with this "inconsistency" between Online and Offline DQM changes/PRs

[fabiocos]

@jfernan2 so this PR was verified in a standalone way?

[jfernan2]

@fabiocos Yes: as any PR going for Online DQM, it is verified first in standalone way by the developer and then in (production) Online DQM. See:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMP5TagCollector
for a complete list of PRs
This leads to the so-called "hanging PRs" issue, but I will write you a private email concerning that problem.

[thomreis]

I never saw that counter being negative to be honest. Even if I have removed histograms.

[fabiocos]

+1