New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to HLT menu version 2.1 (101X) #23293
Conversation
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_1_X. It involves the following packages: Configuration/AlCa @smuzaffar, @Dr15Jones, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @cmsbuild, @fwyzard, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #23292 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: cf840ca You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Comparison is ready Comparison Summary:
|
+1 |
@Dr15Jones can you please also sign the backport for addOntests.py ? |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@Martin-Grunewald sorry, I see that the GRun menu is changed, and this is the menu used in the ongoing 101X MC production. So I assume that the same argument to keep on hold the previous PR is valid also for this one, am I correct? |
Hi, I confirm what @Martin-Grunewald wrote. We also discussed it in the past TSG meeting and added a comment in the Physics Coordination report. Especially EGamma POG strongly support the interest for this new menu |
@Martin-Grunewald @gennai thanks for the comment |
@fabiocos |
+1 after agreement with PPD conveners |
Update to HLT menu version 2.1 (101X)
Based on CMSSW_10_1_X_2018-05-22-2300
Adding also frozen menu dump for @relval2018
Superseeds #23079