Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HLT menu version 2.1 (101X) #23293

Merged
merged 6 commits into from Jun 12, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

Update to HLT menu version 2.1 (101X)
Based on CMSSW_10_1_X_2018-05-22-2300
Adding also frozen menu dump for @relval2018
Superseeds #23079

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_1_X.

It involves the following packages:

Configuration/AlCa
Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@smuzaffar, @Dr15Jones, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @cmsbuild, @fwyzard, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @mmusich, @geoff-smith, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #23292

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28131/console Started: 2018/05/23 15:09

@cmsbuild
Copy link
Contributor

-1

Tested at: cf840ca

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23293/28131/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23293/28140/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498881
  • DQMHistoTests: Total failures: 3483
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2495215
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 22.142 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 10824.0 ): -492.157 KiB HLT/BPH
  • DQMHistoSizes: changed ( 10824.0 ): 289.928 KiB HLT/JME
  • DQMHistoSizes: changed ( 10824.0 ): 124.477 KiB HLT/EGM
  • DQMHistoSizes: changed ( 10824.0 ): 108.571 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 10824.0 ): 49.520 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 10824.0 ): -34.989 KiB HLT/Objects
  • DQMHistoSizes: changed ( 10824.0 ): -26.469 KiB HLT/Higgs
  • DQMHistoSizes: changed ( 10824.0 ): 2.840 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 10824.0 ): 0.391 KiB HLT/Muon
  • DQMHistoSizes: changed ( 10824.0 ): 0.031 KiB HLT/BTV
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@Martin-Grunewald
Copy link
Contributor Author

@arunhep please sign this PR as it superseedes the old #23079

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones can you please also sign the backport for addOntests.py ?
Thanks!

@Dr15Jones
Copy link
Contributor

+1

@lpernie
Copy link
Contributor

lpernie commented May 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Martin-Grunewald sorry, I see that the GRun menu is changed, and this is the menu used in the ongoing 101X MC production. So I assume that the same argument to keep on hold the previous PR is valid also for this one, am I correct?

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
Adding @gennai
Indeed this is the case, but please note that TSG would like this update even for (the next batch of) 101X MC production, as what is currently used is of no interest, not even to POG studies.

@gennai
Copy link
Contributor

gennai commented May 28, 2018

Hi, I confirm what @Martin-Grunewald wrote. We also discussed it in the past TSG meeting and added a comment in the Physics Coordination report. Especially EGamma POG strongly support the interest for this new menu

@fabiocos
Copy link
Contributor

@Martin-Grunewald @gennai thanks for the comment

@klute @franzoni FYI

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
...ping...

@fabiocos
Copy link
Contributor

+1

after agreement with PPD conveners

@cmsbuild cmsbuild merged commit 00b6a8b into cms-sw:CMSSW_10_1_X Jun 12, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLTv21for101X branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants