Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiStripMonitorCluster & SiStripMonitorDigi - Fix the FED digi/cluster plots ranges and error [Backport for 10_1_X of #23307] #23308

Closed
wants to merge 931 commits into from

Conversation

hbecerri
Copy link
Contributor

Fix ranges in the x-axis and errors for NumberOfClustersinFED_v_FEDID and NumberOfDigisinFED_v_FEDID

cmsbuild and others added 30 commits April 18, 2018 10:57
Phase2 Outer Tracker : Incorporating recent changes from TEDD Design + cleaning
This allows dropping the explicit --filein from upgrade HARVESTING.
The parameter will be set in WorkFlowRunner based on the position of
HARVESTING step. Setting it explicitly here basically fixes the
RECO+DQM+VALIDATION step to be number 3 (which won't be the case for
combined premixing stage1+stage2 workflow).

Anyway HARVESTING,ALCA is the typical order in non-upgrade MC
workflows, so this change makes them a tiny bit more consistent.
Fixing Default Values of EgammaHLTGsfTrackVarProducer to be only used if there is a track found : 102X
Temporary protection against missing jet corrector collection
…ucer

Remove Parameter existence check since done by fillDescriptions
revert stream::producer to simple producer to avoid crashes in HTXSRivetProducer
SiStripEventSummary fixes for special runs in local-DAQ
Magnetic Field: Remove Dependency on DDSolidShape
isolate TTree::Fill so IMT doesn't steal long running CMS tasks
Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hbecerri for CMSSW_10_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalTPGAlgos
CalibTracker/Configuration
CalibTracker/SiPixelESProducers
CalibTracker/SiPixelQuality
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripESProducers
CalibTracker/SiStripHitEfficiency
Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
Calibration/IsolatedParticles
CommonTools/RecoAlgos
CommonTools/Statistics
CommonTools/Utils
CondCore/RunInfoPlugins
CondCore/SiPixelPlugins
CondCore/SiStripPlugins
CondCore/Utilities
CondFormats/CTPPSReadoutObjects
CondFormats/Common
CondFormats/DataRecord
CondFormats/JetMETObjects
CondFormats/RunInfo
CondFormats/SiPixelObjects
CondFormats/SiStripObjects
CondTools/BTau
CondTools/Ecal
CondTools/Geometry
CondTools/RunInfo
CondTools/SiStrip
Configuration/AlCa
Configuration/DataProcessing
Configuration/EventContent
Configuration/Generator
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/Skimming
Configuration/StandardSequences
DQM/CTPPS
DQM/DTMonitorModule
DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorTasks
DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
DQM/OuterTrackerL1
DQM/Phase2OuterTracker
DQM/Physics
DQM/SiOuterTracker
DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Config
DQM/SiPixelPhase1DeadFEDChannels
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1RawData
DQM/SiPixelPhase1RecHits
DQM/SiPixelPhase1Track
DQM/SiPixelPhase1TrackClusters
DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals
DQM/SiStripCommissioningAnalysis
DQM/SiStripCommissioningClients
DQM/SiStripCommissioningDbClients
DQM/SiStripCommissioningSources
DQM/SiStripCommissioningSummary
DQM/SiStripCommon
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/TrackingMonitor
DQMOffline/Configuration
DQMOffline/Muon
DQMOffline/Trigger
DQMServices/Components
DQMServices/Core
DQMServices/FileIO
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
DataFormats/Candidate
DataFormats/DetId
DataFormats/ForwardDetId
DataFormats/GeometrySurface
DataFormats/HcalDetId
DataFormats/L1THGCal
DataFormats/L1TMuon
DataFormats/Luminosity
DataFormats/Math
DataFormats/MuonReco
DataFormats/NanoAOD
DataFormats/PatCandidates
DataFormats/SiStripCommon
DataFormats/V0Candidate
DetectorDescription/Core
DetectorDescription/DDCMS
DetectorDescription/OfflineDBLoader
DetectorDescription/Parser
DetectorDescription/RegressionTest
EventFilter/CTPPSRawToDigi
EventFilter/DTRawToDigi
EventFilter/HcalRawToDigi
EventFilter/L1TRawToDigi
EventFilter/SiStripRawToDigi
FWCore/Concurrency
FWCore/Framework
FWCore/Modules
FWCore/ParameterSet
FWCore/PluginManager
FWCore/Services
FWCore/Utilities
FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
FastSimulation/SimplifiedGeometryPropagator
Fireworks/FWInterface
Fireworks/Geometry
GeneratorInterface/Core
GeneratorInterface/CosmicMuonGenerator
GeneratorInterface/GenFilters
GeneratorInterface/LHEInterface
GeneratorInterface/RivetInterface
Geometry/CSCGeometryBuilder
Geometry/CaloGeometry
Geometry/DTGeometryBuilder
Geometry/EcalTestBeam
Geometry/HGCalCommonData
Geometry/HGCalGeometry
Geometry/HcalCommonData
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
Geometry/TrackerRecoData
Geometry/TrackerSimData
Geometry/VeryForwardData
HLTrigger/Configuration
HLTrigger/Muon
HLTriggerOffline/Btag
HLTriggerOffline/Exotica
HeavyFlavorAnalysis/Onia2MuMu
IOPool/Output
JetMETCorrections/Modules
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTriggerPrimitives
L1Trigger/Configuration
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonCPPF
L1Trigger/L1TMuonEndCap
L1Trigger/TrackTrigger
MagneticField/GeomBuilder
MagneticField/VolumeGeometry
MuonAnalysis/MuonAssociators
OnlineDB/SiStripConfigDb
OnlineDB/SiStripO2O
PhysicsTools/CondLiteIO
PhysicsTools/KinFitter
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
PhysicsTools/RecoAlgos
PhysicsTools/TagAndProbe
PhysicsTools/TensorFlow
RecoBTag/Combined
RecoCTPPS/Configuration
RecoEgamma/EgammaHLTProducers
RecoEgamma/PhotonIdentification
RecoJets/JetProducers
RecoLocalCalo/Castor
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoLocalFastTime/FTLRecProducers
RecoLocalTracker/Records
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripRecHitConverter
RecoLocalTracker/SubCollectionProducers
RecoMuon/MuonIsolation
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFClusterTools
RecoParticleFlow/PFSimProducer
RecoTauTag/Configuration
RecoTracker/TkNavigation
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
RecoVertex/AdaptiveVertexFinder
SLHCUpgradeSimulations/Geometry
SimCalorimetry/CastorSim
SimCalorimetry/EcalSimProducers
SimCalorimetry/HGCalSimProducers
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalTestBeam
SimDataFormats/CaloHit
SimDataFormats/GeneratorProducts
SimFastTiming/FastTimingCommon
SimG4CMS/Calo
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/CustomPhysics
SimG4Core/Geometry
SimG4Core/HelpfulWatchers
SimG4Core/MagneticField
SimG4Core/Notification
SimG4Core/Physics
SimG4Core/PhysicsLists
SimG4Core/PrintGeomInfo
SimGeneral/CaloAnalysis
SimGeneral/DataMixingModule
SimGeneral/Debugging
SimGeneral/MixingModule
SimGeneral/PreMixingModule
SimGeneral/TrackingAnalysis
SimMuon/CSCDigitizer
SimMuon/Configuration
SimMuon/DTDigitizer
SimMuon/MCTruth
SimMuon/RPCDigitizer
SimTracker/SiPhase2Digitizer
SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer
SimTracker/TrackAssociation
SimTracker/TrackAssociatorProducers
SimTracker/TrackHistory
SimTracker/TrackTriggerAssociation
SimTracker/TrackerHitAssociation
TopQuarkAnalysis/TopPairBSM
TrackPropagation/RungeKutta
TrackPropagation/SteppingHelixPropagator
TrackingTools/KalmanUpdators
Validation/CaloTowers
Validation/Configuration
Validation/GlobalDigis
Validation/GlobalRecHits
Validation/HGCalValidation
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits
Validation/MuonCSCDigis
Validation/MuonDTDigis
Validation/MuonRPCDigis
Validation/OuterTrackerL1V
Validation/RPCRecHits
Validation/RecoHI
Validation/RecoMuon
Validation/RecoTrack
Validation/RecoVertex
Validation/SiOuterTrackerV
Validation/SiPixelPhase1HitsV
Validation/SiPixelPhase1TrackingParticleV
Validation/TrackerHits
Validation/TrackerRecHits
Validation/TrackingMCTruth

The following packages do not have a category, yet:

DQM/OuterTrackerL1
Validation/OuterTrackerL1V
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@lveldere, @ianna, @kpedro88, @fabozzi, @nsmith-, @rekovic, @thomreis, @alberto-sanchez, @vanbesien, @arizzi, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @efeyazgan, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @fabiocos, @ssekmen, @Martin-Grunewald, @prebello, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @dmitrijus, @alja, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks.
@yslai, @felicepantaleo, @sviret, @ghugo83, @Martin-Grunewald, @bsunanda, @thomreis, @varuns23, @sethzenz, @imarches, @ahinzmann, @jdolen, @prolay, @drkovalskyi, @ferencek, @rociovilar, @barvic, @rovere, @jdamgov, @ebrondol, @dgulhan, @batinkov, @gbenelli, @calderona, @gpetruc, @bachtis, @erikbutz, @forthommel, @kpedro88, @argiro, @fioriNTU, @alberto-sanchez, @alja, @jhgoh, @lgray, @valuev, @HuguesBrun, @ptcox, @trocino, @GiacomoSguazzoni, @VinInn, @bellan, @nhanvtran, @gkasieczka, @schoef, @idebruyn, @namapane, @battibass, @wddgit, @makortel, @mverzett, @cbernet, @mariadalfonso, @amarini, @pvmulder, @folguera, @echabert, @rappoccio, @jainshilpi, @threus, @geoff-smith, @seemasharmafnal, @venturia, @mmarionncern, @kreczko, @yduhm, @vandreev11, @Sam-Harper, @cseez, @mmusich, @mtosi, @amagitte, @echapon, @mkirsano, @dkotlins, @pfs, @TaiSakuma, @gouskos, @abbiendi, @nickmccoll, @jbsauvan, @hdelanno, @acaudron, @agrohsje, @dildick, @OlivierBondu, @kkrajczar, @tocheng, @wmtford, @mschrode, @swertz, @edjtscott, @JyothsnaKomaragiri, @rylanC24, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

This needs to be rebased so it only includes the commits actually needed.

@perrotta
Copy link
Contributor

-1
rebase needed

@Martin-Grunewald
Copy link
Contributor

-1

@kpedro88
Copy link
Contributor

-1
please follow http://cms-sw.github.io/tutorial-resolve-conflicts.html#backporting-a-pr to backport your PR correctly

@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

-1

@ianna
Copy link
Contributor

ianna commented Jun 5, 2018

-1

@boudoul
Copy link
Contributor

boudoul commented Jun 5, 2018

please @hbecerri , close this PR !
[the backport is actually here #23329 ]

@hbecerri hbecerri closed this Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment