SiStripMonitorCluster & SiStripMonitorDigi - Fix the FED digi/cluster plots ranges and error [Backport for 10_1_X of #23307] #23329
Conversation
|
A new Pull Request was created by @hbecerri for CMSSW_10_1_X. It involves the following packages: DQM/SiStripMonitorCluster @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -518,7 +518,7 @@ void SiStripMonitorDigi::createMEs(DQMStore::IBooker & ibooker , const edm::Even | |||
| FEDDigi.getParameter<double>("xmax"), | |||
| FEDDigi.getParameter<int32_t>("Nbinsy"), | |||
| FEDDigi.getParameter<double>("ymin"), | |||
| FEDDigi.getParameter<double>("ymax")); | |||
| FEDDigi.getParameter<double>("ymax"),""); | |||
There was a problem hiding this comment.
This change does not make sense. Can you explain what your trying to do here?
There was a problem hiding this comment.
it makes sense, if we do not add the blank string the errors in the TProfile are computed with the RMS of the bins, adding this instead we get the errors as the RMS/sqrt(entries in the bin) that is what we want to have in the plot since this is the correct error on the average value
|
backport of #23307 Instead of putting a PR number to the title, simply add link to the description. |
|
@vazzolini, @kmaeshima, @dmitrijus, @jfernan2, @vanbesien , could you please review this PR ? Thanks |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
No description provided.