Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixel MergedDeadROCOccupancy Maps to TkMap script and FPix panel bug patch (backport to 10_1_X of #23339) #23367

Merged
merged 1 commit into from Jun 7, 2018

Conversation

arossi83
Copy link
Contributor

Changes only on Offline Shifter tools, no changes on production workflow

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2018

A new Pull Request was created by @arossi83 (Alessandro Rossi) for CMSSW_10_1_X.

It involves the following packages:

DQM/SiStripMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28249/console Started: 2018/05/29 12:12

@dmitrijus
Copy link
Contributor

backport of #23339

@dmitrijus
Copy link
Contributor

Welcome @arossi83

Why does this PR have more changes than the one in master?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@arossi83
Copy link
Contributor Author

@dmitrijus Some changes on the index_template files where not backported previously to 10_1_X, so now they are included here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23367/28249/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498020
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497843
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

+1

merged in master, affecting only online tools

@cmsbuild cmsbuild merged commit ed7de8e into cms-sw:CMSSW_10_1_X Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants