Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71 x photon #2345

Merged
merged 5 commits into from Feb 7, 2014
Merged

71 x photon #2345

merged 5 commits into from Feb 7, 2014

Conversation

monttj
Copy link
Contributor

@monttj monttj commented Feb 7, 2014

  1. Add access functions for PF isolation to pat::Photon
  2. Add PF isolation to PAT leptons
  3. Remove some obsolete integration tests.

monttj and others added 5 commits February 6, 2014 22:38
…d 2.change the token argument as reference for the function readIsolationLabels for muon,electron and photon producer and 3.make particle flow isolation turn on as default for muon,electron and photon.
…X-photon

Use this branch in CMSSW_7_1_X_2014-02-06-0200 or later.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

A new Pull Request was created by @monttj (Tae Jeong Kim) for CMSSW_7_1_X.

71 x photon

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2345/60/summary.html

@vadler
Copy link

vadler commented Feb 7, 2014

@cmsbuild : The errors are always about Exception: There are not files in input from the file list. This does not seem to be a problem uf this PR.

@nclopezo
Copy link
Contributor

nclopezo commented Feb 7, 2014

@vadler
Copy link

vadler commented Feb 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 7, 2014
@nclopezo nclopezo merged commit bb50dd7 into cms-sw:CMSSW_7_1_X Feb 7, 2014
@monttj monttj deleted the 71X-photon branch February 7, 2014 13:24
@vadler vadler mentioned this pull request Feb 7, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants