New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hdrs CommonTools #23463
fix hdrs CommonTools #23463
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23463/5001 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: CommonTools/PileupAlgos @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -13,6 +13,8 @@ | |||
#include "FWCore/ParameterSet/interface/ParameterSet.h" | |||
#include "DataFormats/Math/interface/PtEtaPhiMass.h" | |||
#include "DataFormats/Candidate/interface/Candidate.h" | |||
#include "DataFormats/ParticleFlowCandidate/interface/PFCandidate.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two includes can be removed from PuppiPhoton.cc, then
@@ -12,7 +12,10 @@ | |||
#include "FWCore/Framework/interface/EventSetup.h" | |||
#include "FWCore/ParameterSet/interface/ParameterSet.h" | |||
#include "DataFormats/Math/interface/PtEtaPhiMass.h" | |||
|
|||
#include "DataFormats/Math/interface/LorentzVector.h" | |||
#include "DataFormats/VertexReco/interface/VertexFwd.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three includes can be removed from PuppiProducer.cc, then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll check more careful what could be removed then
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23463/5042 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
merge |
Fix headers related to #15248