Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498 #23528

Merged
merged 1 commit into from Jun 12, 2018
Merged

[10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498 #23528

merged 1 commit into from Jun 12, 2018

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 8, 2018

backport of #23523
as a reminder this is needed, because without this change, once the MC AlCaReco TriggerBits for the SiStripCalMinBias ALCARECO producer are activated (as it is done e.g. in #23498) the module ALCARECOSiStripCalMinBiasTrackingDQM will fail with:

----- Begin Fatal Exception 06-Jun-2018 00:47:08 CEST-----------------------
An exception of category 'NoRecord' occurred while
[0] Processing Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'pathALCARECOSiStripCalMinBias'
[2] Calling method for module TrackingMonitor/'ALCARECOSiStripCalMinBiasTrackingDQM'
Exception Message:
No "TransientTrackRecord" record found in the EventSetup.n
Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

In turn the activation of the of the Trigger Bits is needed to be able to generate a sample of SiStripCalMinBias events to derive the G2 calibration for the physics MC in 10.2.X.

@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Jun 8, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018 •
edited

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_1_X.

It involves the following packages:

DQMOffline/CalibTracker

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title Fix for AlCaSiStripCalMinBias as discussed on PR #23498 ][10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498 Jun 8, 2018
@mmusich mmusich changed the title ][10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498 [10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498 Jun 8, 2018
@jfernan2
Copy link
Contributor

jfernan2 commented Jun 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28563/console Started: 2018/06/08 15:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

+1
Tested at: f0425ae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23528/28563/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison job queued.

@lpernie
Copy link
Contributor

lpernie commented Jun 8, 2018

Hi @fabiocos
This PR passed the standard tests. There are several workflows affected by this PR and not tested by default.
Once comparison is available I will test some of them:
4.24 WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
4.28 HighMet2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
4.74 RunEl2012D+HLTD+RECODR1reHLT+HARVESTDR1reHLT
4.78 WElSkim2012D+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
134.702 RunDoubleEG2015B+HLTDR2_50ns+RECODR2_50nsreHLT_HIPM+HARVESTDR2
134.703 RunDoubleMuon2015B+HLTDR2_50ns+RECODR2_50nsreHLT_HIPM+HARVESTDR2
134.912 RunZeroBias2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
135.1 TTbarFS_13+HARVESTUP15FS+MINIAODMCUP15FS
136.722 RunDoubleEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimDoubleEG_HIPM+HARVESTDR2
136.723 RunDoubleMuon2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2
136.726 RunMuonEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2
136.728 RunSingleMuPrpt2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23528/28563/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2522427
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2522250
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.312 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 136.731,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Jun 8, 2018

please test workflow 4.24, 4.28, 4.74, 4.78, 134.702, 134.703, 134.912, 135.1, 136.722, 136.723, 136.726, 136.728

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28579/console Started: 2018/06/08 19:41

@lpernie
Copy link
Contributor

lpernie commented Jun 8, 2018

please test workflow 4.24, 4.28, 4.74, 4.78, 134.702, 134.703, 134.912, 135.1, 136.722, 136.723, 136.726, 136.728

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28588/console Started: 2018/06/09 02:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

+1
Tested at: f0425ae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23528/28588/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23528/28588/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/134.912_RunZeroBias2015D+RunZeroBias2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/135.1_TTbar_13+TTbarFS_13+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/136.726_RunMuonEG2016B+RunMuonEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/4.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/4.28_HighMet2011A+HighMet2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/4.74_RunEl2012D+RunEl2012D+HLTD+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23528/4.78_WElSkim2012D+WElSkim2012D+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2522427
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2522250
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.312 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Jun 9, 2018

@cmsdqm @jfernan2 could you please sign #23523 and this PR? The tests I made are workflows affected, so there should not be problem in IB @fabiocos .

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 9, 2018 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@lpernie
Copy link
Contributor

lpernie commented Jun 11, 2018

@fabiocos something else is needed here?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e2a203b into cms-sw:CMSSW_10_1_X Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmusich @cmsbuild @jfernan2 @lpernie @fabiocos