Disable hcalLaserEventFilter occupancy filter #23597

jkunkle · 2018-06-15T14:28:31Z

We found that the occupancy filter in the hcalLaserEventFilter is erroneously removing good events. We think that increasing the threshold to 8000 would be sufficient, but we also simply disable it in favor of the LaserMon filter. We use the eras to ensure that the settings are only updated for 2018 data.

@deguio @mariadalfonso

…re studies)

cmsbuild · 2018-06-15T14:28:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-15T14:31:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23597/5201

cmsbuild · 2018-06-15T14:31:50Z

A new Pull Request was created by @jkunkle for master.

It involves the following packages:

RecoMET/METFilters

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jkunkle · 2018-06-15T14:35:14Z

To test one can run these steps

cmsrel CMSSW_10_2_X_2018-06-14-1100 # or a reasonably new release
cd CMSSW_10_2_X_2018-06-14-1100/src/
cmsenv
git cms-merge-topic 23597
cp -r /afs/cern.ch/user/j/jkunkle//public/HcalLaserCodeTest2/* .
scram b -j8
cmsDriver.py step1 --conditions 101X_dataRun2_Prompt_v9 -s RAW2DIGI,RECO --data --era Run2_2018 --eventcontent RECO,AOD --datatier RECO,AOD --filein root://eoscms.cern.ch//eos/cms/store/data/Run2018A/JetHT/RAW/v1/000/316/995/00000/FAEDC5AE-6F62-E811-AB45-02163E01A095.root  -n 100   --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018
cmsDriver.py step2 --filein file:step1_RAW2DIGI_RECO.root  --data --eventcontent MINIAOD --runUnscheduled --datatier MINIAOD --conditions 101X_dataRun2_Prompt_v9  --step PAT   --era Run2_2018 -n 100
cmsRun config_test.py

At the end you should see an output like

N events that Pass METFilter and Pass Charge cut = 100 -- GOOD!
N events that Fail METFilter and Fail Charge cut = 0 -- BAD!
N events that Pass METFilter and Fail Charge cut = 0 -- GOOD!
N events that Fail METFilter and Pass Charge cut = 0 -- GOOD!

This is the expected output since the laser was not firing. If instead one comments out the changes here and reruns

cmsDriver.py step2 --filein file:step1_RAW2DIGI_RECO.root  --data --eventcontent MINIAOD --runUnscheduled --datatier MINIAOD --conditions 101X_dataRun2_Prompt_v9  --step PAT   --era Run2_2018 -n 100
cmsRun config_test.py

You see a different output with most events failing the MET filter

perrotta · 2018-06-15T14:43:37Z

please test

cmsbuild · 2018-06-15T14:43:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28713/console Started: 2018/06/15 16:44

cmsbuild · 2018-06-15T16:59:14Z

+1
Tested at: 6ec515e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23597/28713/summary.html

cmsbuild · 2018-06-15T16:59:16Z

Comparison job queued.

cmsbuild · 2018-06-15T18:16:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23597/28713/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902004
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901813
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

perrotta · 2018-06-18T15:30:47Z

RecoMET/METFilters/python/hcalLaserEventFilter_cfi.py

+
+from Configuration.Eras.Modifier_run2_HCAL_2018_cff import run2_HCAL_2018
+run2_HCAL_2018.toModify( hcalLaserEventFilter,
+                           vetoByHBHEOccupancy = cms.bool( False),


Please drop type specification: types were already defined, and removing it here may help catching possible mistypes

cmsbuild · 2018-06-20T11:23:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-20T11:26:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23597/5266

cmsbuild · 2018-06-20T11:27:16Z

Pull request #23597 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

perrotta · 2018-06-20T11:42:19Z

please test

cmsbuild · 2018-06-20T11:42:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28782/console Started: 2018/06/20 13:44

cmsbuild · 2018-06-20T14:02:47Z

+1
Tested at: 864d49c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23597/28782/summary.html

cmsbuild · 2018-06-20T14:02:50Z

Comparison job queued.

cmsbuild · 2018-06-20T15:22:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23597/28782/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902133
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901941
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

perrotta · 2018-06-20T16:18:03Z

+1

One MET filter is disabled, as it was found to remove too many events (its threshold was already adjusted in previous updates of that filter, now they decide to disable it at all while waiting for further studies to decide an optimal one)
No effect is visible in the limited stat of the jenkins tests (no laser firing in the tested samples)

fabiocos · 2018-06-20T16:25:20Z

+1

fabiocos · 2018-06-20T16:25:25Z

merge

Disable occupancy filter and increase the threshold to 8000 (for futu…

6ec515e

…re studies)

cmsbuild added this to the CMSSW_10_2_X milestone Jun 15, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 15, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 15, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 15, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 15, 2018

perrotta reviewed Jun 18, 2018

View reviewed changes

remove types

864d49c

cmsbuild removed code-checks-approved comparison-available labels Jun 20, 2018

cmsbuild added code-checks-pending comparison-pending tests-pending and removed tests-approved labels Jun 20, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 20, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 20, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 20, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 20, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 20, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 20, 2018

cmsbuild merged commit c1be34f into cms-sw:master Jun 20, 2018

deguio mentioned this pull request Jun 25, 2018

Update the ADC->fC table, simplify the charge reconstruction algorithm #22976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable hcalLaserEventFilter occupancy filter #23597

Disable hcalLaserEventFilter occupancy filter #23597

jkunkle commented Jun 15, 2018 •

edited

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

jkunkle commented Jun 15, 2018

perrotta commented Jun 15, 2018

cmsbuild commented Jun 15, 2018 •

edited

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

perrotta Jun 18, 2018

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

perrotta commented Jun 20, 2018

cmsbuild commented Jun 20, 2018 •

edited

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

perrotta commented Jun 20, 2018

fabiocos commented Jun 20, 2018

fabiocos commented Jun 20, 2018

Disable hcalLaserEventFilter occupancy filter #23597

Disable hcalLaserEventFilter occupancy filter #23597

Conversation

jkunkle commented Jun 15, 2018 • edited

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

jkunkle commented Jun 15, 2018

perrotta commented Jun 15, 2018

cmsbuild commented Jun 15, 2018 • edited

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

cmsbuild commented Jun 15, 2018

perrotta Jun 18, 2018

Choose a reason for hiding this comment

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

perrotta commented Jun 20, 2018

cmsbuild commented Jun 20, 2018 • edited

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

cmsbuild commented Jun 20, 2018

perrotta commented Jun 20, 2018

fabiocos commented Jun 20, 2018

fabiocos commented Jun 20, 2018

jkunkle commented Jun 15, 2018 •

edited

cmsbuild commented Jun 15, 2018 •

edited

cmsbuild commented Jun 20, 2018 •

edited