[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

pieterdavid · 2018-06-19T08:53:24Z

backport of #23417
(as discussed in last Friday's reco meeting (see this contribution))

No changes in the tests are expected, except (as in the 10_2 PR) for warnings:

in 140.53 (repacked 2011 HI data) about an invalid packet code (0 for non-lite zero-suppressed data), which is due to a pre-2015 packer bug that is worked around in the unpacker
about missing data from FED 87 for 1000.0 and 1001.0 (2011 minimum bias, run 165121), and from FEDs 87, 135 and 137 for the 4.22 test (2011 cosmics, run 160960). These were silenced before, and are all understood and not related to the changes done here.

CC: @alesaggio @OlivierBondu @vidalm @mmusich @echabert @erikbutz

- rename the PACKET_CODE definitions for ZS lite to ZS - change the packetCode implementation: default (0) for ZS lite modes, taken from the third byte for ZS Reason: for ZS lite there are no packet codes, the packing scheme is given by the readout mode; for non-lite ZS it is in the channel data

- add "PacketCode" option to SiStripDigiToRawModule - add packetCodeFromString conversion in SiStripFEDBufferComponents - pass the packet code on to FEDBufferPayloadCreator::fillChannelBuffer

workaround for a bug in the pre-2015 packer (eg. 140.53_RunHI2011)

In debug mode all messages are still printed, otherwise a summary (warning type and count) is printed after unpacking the event.

cmsbuild · 2018-06-19T08:53:43Z

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_10_1_X.

It involves the following packages:

Configuration/StandardSequences
EventFilter/SiStripRawToDigi
RecoLocalTracker/SiPixelClusterizer
SimTracker/SiPixelDigitizer

@perrotta, @civanch, @mdhildreth, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dkotlins, @gpetruc, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23417

perrotta · 2018-06-19T10:39:21Z

please test

cmsbuild · 2018-06-19T13:01:02Z

+1
Tested at: 457a4af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23620/28756/summary.html

cmsbuild · 2018-06-19T13:01:05Z

Comparison job queued.

cmsbuild · 2018-06-19T14:50:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23620/28756/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2523210
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2523033
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
Checked 119 log files, 9 edm output root files, 29 DQM output files

perrotta · 2018-06-19T15:10:30Z

+1

This is identical commit-wise and code wise to SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23417, now merged in the master
SiStrip unpacker adapted for non-standard ZS modes as described: user tests show that the unpacked data reproduce the input ones
No effect is visible in standard workflows, where those non-standard ZS modes are not at work
Warning messages have also been reorganized and improved: this generates an extra warning (once per job) in the 2011 pp workflows. It was investigated, but it remains outside the scope of this PR

civanch · 2018-06-19T17:56:57Z

+1

boudoul · 2018-06-26T09:43:08Z

Dear @fabiocos - Would it be possible to get this integrated in the next 10_1_X in order to make it available for operation ? Thanks

slava77 · 2018-07-09T07:33:55Z

@fabiocos
please clarify the plans for this PR, if it will be added to 10_1_X soon.
Thank you.

mmusich · 2018-07-12T10:33:02Z

@fabiocos may I ask if there is at this point any plan to include this PR in the 10_1_X cycle or shall we just have in post-TS2 data in 10_2_X? This is somehow a nuisance for continuing tests on the HW side at P5.

fabiocos · 2018-07-13T07:34:18Z

@mmusich @boudoul what is the outcome of the tracker validation in pre6? I was monitoring that to integrate this asap, but I did not see any report in valDB so far

mmusich · 2018-07-13T07:47:26Z

@fabiocos, indeed the data report is missing (which is a pity) and the report from @boudoul on simulation (https://hypernews.cern.ch/HyperNews/CMS/get/relval/10839.html) is indeed still open (likely because of many changes introduced in the pixel detector) but a quick look at Strip workspace pointed in the "work in progress" report (https://goo.gl/ThZvmN) makes me conclude that the outcome is positive (I do not see catastrophically wrong changes).
Also, all the other subsystem that depend on the Strip Tracker (such as Tracking) have signed off the data campaign (https://hypernews.cern.ch/HyperNews/CMS/get/relval/10815/6.html), but I agree it would be better to get the Tracker data report (as it is clean from other changes in conditions that have happened in simulation).

fabiocos · 2018-07-16T07:48:10Z

+operations

backport from master

cmsbuild · 2018-07-16T07:48:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-07-16T07:48:59Z

+1

Tracker validation of CMSSW_10_2_0_pre6 is reported ok

boudoul · 2018-07-16T07:59:46Z

Thanks @fabiocos , do you have an estimate when 10_1_9 will come ? In our case the earlier , the better

pieterdavid and others added 20 commits June 19, 2018 09:05

Add other ZS modes to SiStripRawToDigiUnpacker

40366d5

Fix uninitialized member in FEDBSChannelUnpacker

d805d8a

A few more FEDBSChannelUnpacker fixes

f7cc97f

Add packet code option for SiStripDigiToRawModule

6346845

- add "PacketCode" option to SiStripDigiToRawModule - add packetCodeFromString conversion in SiStripFEDBufferComponents - pass the packet code on to FEDBufferPayloadCreator::fillChannelBuffer

Fix a regression for VR10 unpacking

f40bb0c

use an InputTag in SiStripDigiToRawModule

166d4a8

adding VR packet code cases

6fe0b3a

Fix FEDBSChannelUnpacker::hasData for other sizes than 10 and 16

29a0e9d

VR and ZR fixed

d3cb8b0

ZS packer patch: cleanup

de7d654

Packer: use ZS code also for ZS lite

f5a1e72

packer: readout mode parsing and empty default packet code

192dafc

also for ZS packer: push directly packet code

f07ab5c

code checks fixes (empty string tests)

16b614a

Update configs to changes in SiStripDigiToRaw parameters

a8c4c66

Use default ZS packing if the packet code is zero

bd56025

workaround for a bug in the pre-2015 packer (eg. 140.53_RunHI2011)

Print SiStrip unpacker warnings and exceptions once per event

8acbeb9

In debug mode all messages are still printed, otherwise a summary (warning type and count) is printed after unpacking the event.

strip unpacker: print warnings on first occurrence, summary in endStream

8904c37

sistrip::FEDBSChannelUnpacker: use BITS_PER_BYTE constant instead of 8

457a4af

cmsbuild added this to the CMSSW_10_1_X milestone Jun 19, 2018

cmsbuild added comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Jun 19, 2018

cmsbuild added the tests-started label Jun 19, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 19, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 19, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 19, 2018

cmsbuild added simulation-approved and removed simulation-pending labels Jun 19, 2018

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Jul 16, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 16, 2018

cmsbuild merged commit ba9947a into cms-sw:CMSSW_10_1_X Jul 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

pieterdavid commented Jun 19, 2018 •

edited

cmsbuild commented Jun 19, 2018 •

edited

perrotta commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

perrotta commented Jun 19, 2018

civanch commented Jun 19, 2018

boudoul commented Jun 26, 2018

slava77 commented Jul 9, 2018

mmusich commented Jul 12, 2018

fabiocos commented Jul 13, 2018

mmusich commented Jul 13, 2018

fabiocos commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

fabiocos commented Jul 16, 2018

boudoul commented Jul 16, 2018

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

Conversation

pieterdavid commented Jun 19, 2018 • edited

cmsbuild commented Jun 19, 2018 • edited

perrotta commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

cmsbuild commented Jun 19, 2018

perrotta commented Jun 19, 2018

civanch commented Jun 19, 2018

boudoul commented Jun 26, 2018

slava77 commented Jul 9, 2018

mmusich commented Jul 12, 2018

fabiocos commented Jul 13, 2018

mmusich commented Jul 13, 2018

fabiocos commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

fabiocos commented Jul 16, 2018

boudoul commented Jul 16, 2018

pieterdavid commented Jun 19, 2018 •

edited

cmsbuild commented Jun 19, 2018 •

edited