Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

Merged
merged 20 commits into from Jul 16, 2018
Merged

[10_1_X] SiStrip (un)packer: fixes and support for nonstandard ZS(lite) modes #23620

merged 20 commits into from Jul 16, 2018

Commits on Jun 19, 2018

  1. Fix packet codes for ZS and ZS lite 

    - rename the PACKET_CODE definitions for ZS lite to ZS
- change the packetCode implementation: default (0) for ZS lite modes,
  taken from the third byte for ZS
Reason: for ZS lite there are no packet codes, the packing scheme
is given by the readout mode; for non-lite ZS it is in the channel data
    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    b83531c View commit details
    Browse the repository at this point in the history

  2. Add other ZS modes to SiStripRawToDigiUnpacker

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    40366d5 View commit details
    Browse the repository at this point in the history

  3. Fix uninitialized member in FEDBSChannelUnpacker

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    d805d8a View commit details
    Browse the repository at this point in the history

  4. A few more FEDBSChannelUnpacker fixes

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    f7cc97f View commit details
    Browse the repository at this point in the history

  5. Add packet code option for SiStripDigiToRawModule 

    - add "PacketCode" option to SiStripDigiToRawModule
- add packetCodeFromString conversion in SiStripFEDBufferComponents
- pass the packet code on to FEDBufferPayloadCreator::fillChannelBuffer
    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    6346845 View commit details
    Browse the repository at this point in the history

  6. Fix a regression for VR10 unpacking

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    f40bb0c View commit details
    Browse the repository at this point in the history

  7. use an InputTag in SiStripDigiToRawModule

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    166d4a8 View commit details
    Browse the repository at this point in the history

  8. adding VR packet code cases

    @alesaggio @pieterdavid
    alesaggio authored and pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    6fe0b3a View commit details
    Browse the repository at this point in the history

  9. Fix FEDBSChannelUnpacker::hasData for other sizes than 10 and 16

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    29a0e9d View commit details
    Browse the repository at this point in the history

  10. VR and ZR fixed

    @alesaggio @pieterdavid
    alesaggio authored and pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    d3cb8b0 View commit details
    Browse the repository at this point in the history

  11. ZS packer patch: cleanup

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    de7d654 View commit details
    Browse the repository at this point in the history

  12. Packer: use ZS code also for ZS lite

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    f5a1e72 View commit details
    Browse the repository at this point in the history

  13. packer: readout mode parsing and empty default packet code

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    192dafc View commit details
    Browse the repository at this point in the history

  14. also for ZS packer: push directly packet code

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    f07ab5c View commit details
    Browse the repository at this point in the history

  15. code checks fixes (empty string tests)

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    16b614a View commit details
    Browse the repository at this point in the history

  16. Update configs to changes in SiStripDigiToRaw parameters

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a8c4c66 View commit details
    Browse the repository at this point in the history

  17. Use default ZS packing if the packet code is zero 

    workaround for a bug in the pre-2015 packer (eg. 140.53_RunHI2011)
    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    bd56025 View commit details
    Browse the repository at this point in the history

  18. Print SiStrip unpacker warnings and exceptions once per event 

    In debug mode all messages are still printed, otherwise a summary
(warning type and count) is printed after unpacking the event.
    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    8acbeb9 View commit details
    Browse the repository at this point in the history

  19. strip unpacker: print warnings on first occurrence, summary in endStream

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    8904c37 View commit details
    Browse the repository at this point in the history

  20. sistrip::FEDBSChannelUnpacker: use BITS_PER_BYTE constant instead of 8

    @pieterdavid
    pieterdavid committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    457a4af View commit details
    Browse the repository at this point in the history