Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy forwarding for PV and Z->mumu validations #23761

Merged
merged 1 commit into from Jul 11, 2018

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 6, 2018

Simple bugfix. I covered most of the validations we run in 84974aa, but missed setting the env variable in these two cases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

The code-checks are being triggered in jenkins.

@hroskes
Copy link
Contributor Author

hroskes commented Jul 6, 2018

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

A new Pull Request was created by @hroskes (Heshy Roskes) for master.

It involves the following packages:

Alignment/OfflineValidation

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29035/console Started: 2018/07/06 16:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

-1

Tested at: 095309c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23761/29035/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29058/console Started: 2018/07/10 15:39

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23761/29058/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899490
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899298
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@lpernie @arunhep this is a merely technical fix that I assume is not tested by the regular procedure.

@lpernie
Copy link
Contributor

lpernie commented Jul 11, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6574c47 into cms-sw:master Jul 11, 2018
@hroskes hroskes deleted the tkal-validation-forward-proxy branch October 29, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants