New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy forwarding for PV and Z->mumu validations #23761
Conversation
The code-checks are being triggered in jenkins. |
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23761/5434 |
A new Pull Request was created by @hroskes (Heshy Roskes) for master. It involves the following packages: Alignment/OfflineValidation @arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 095309c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Simple bugfix. I covered most of the validations we run in 84974aa, but missed setting the env variable in these two cases.