Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of 9_4_9_cand2 to 9_4_X on top of cand1 backport #23789

Merged
merged 1 commit into from Jul 13, 2018

Conversation

fabiocos
Copy link
Contributor

Obtained on top of 9_4_X after the merge of #23549 , i.e.

commit 68e825f (origin/CMSSW_9_4_X, CMSSW_9_4_X)
Merge: f26d758 b09e4a5
Author: cmsbuild cmsbuild@cern.ch
Date: Fri Jul 13 14:58:25 2018 +0200

Merge pull request #23549 from fabiocos/fc-MAODbackport

Add 9_4_9_cand1 content on top of 9_4_X as a patch

with

git diff --no-prefix fc-cand2TO94X-only..remotes/origin/CMSSW_9_4_MAOD_X

and applying the patch to 9_4_X

After the patch is applied "git diff fc-cand2TO94X-only..remotes/origin/CMSSW_9_4_MAOD_X" gives an empty output, i.e. the synchronization between the two branches is complete

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_X.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29105/console Started: 2018/07/13 16:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23789/29105/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1352 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 2835
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718496
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

technical backport of additions already approved by reconstruction in CMSSW_9_4_MAOD_X

@cmsbuild cmsbuild merged commit 890eaa2 into cms-sw:CMSSW_9_4_X Jul 13, 2018
@fabiocos fabiocos deleted the fc-cand2TO94X-only branch November 2, 2018 09:23
@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants