Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two by-lumisection plots to ECAL DQM, backport to CMSSW 10_1_X #23921

Closed

Conversation

tanmaymudholkar
Copy link
Contributor

@tanmaymudholkar tanmaymudholkar commented Jul 21, 2018

(1) Added new by-lumisection plots to monitor the behavior of TTF4 flags
(2) Fixed the TTF4 trend plots to display number of masked towers only from the current lumisection.

PR for CMSSW master: 23920
Backport to 10_2_X: 23952
PR for DQM deployment: 652

… and filled the TTF4 trend plots with masking status from the current lumisection only.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_10_1_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29325/console Started: 2018/07/23 12:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23921/29325/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2520647
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2520470
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3215.729 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 25202.0,... ): 162.824 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 25202.0,... ): 20.934 KiB EcalBarrel/EBTriggerTowerTask
  • DQMHistoSizes: changed ( 4.22,... ): 81.404 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 4.22,... ): 10.463 KiB EcalBarrel/EBTriggerTowerTask
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@tanmaymudholkar
Copy link
Contributor Author

Hi @andrius-k , @fabiocos and others -- this PR is a backport of 23920 which was merged already in master. In addition, there was another backport to 10_2_X meant to be deployed in production at P5; this was also merged. I guess this PR is obsolete now -- should I close it?

@andrius-k
Copy link

Hi Tanmay,

Since there will be no more 10_1 releases this can be closed.

@tanmaymudholkar
Copy link
Contributor Author

OK, thanks! Closing.

@tanmaymudholkar tanmaymudholkar deleted the TTF4ByLS_10_1_8 branch August 31, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants