Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized muon validation #2409

Merged
merged 2 commits into from Feb 16, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Feb 11, 2014

optimized muon validation sequence.
for info: differs from #2404

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_6_2_X_SLHC.

optimized muon validation

It involves the following packages:

Validation/RecoMuon

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor Author

deguio commented Feb 12, 2014

@cmsbuild
could you please test this pull please?

F.

@cmsbuild
Copy link
Contributor

Pull request #2409 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@andersonjacob
Copy link
Contributor

This passes our validation with only the known failures.

@deguio
Copy link
Contributor Author

deguio commented Feb 13, 2014

+1
thanks @andersonjacob

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

Tested on latest integration build. Extended pixel test okay. GEM test okay. All tests pass except 3400 crashing with the MonitorElement stack trace. Don't think this has anything to do with this pull request though, see the comments on #2405. Need to figure out exactly what's going on before we can proceed with this.

@mark-grimes
Copy link

merge

Above error is unrelated to this pull request and has been fixed. Extended pixel test; GEM test; 3300, 3400, 4100, 4400, 40001, 50002, 60002, 4502, 4500, 5001 and 15001 all fine.

cmsbuild added a commit that referenced this pull request Feb 16, 2014
@cmsbuild cmsbuild merged commit f13dbcf into cms-sw:CMSSW_6_2_X_SLHC Feb 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants