MTD RECO code update #24241
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| #include "RecoLocalFastTime/FTLCommonAlgos/interface/MTDUncalibratedRecHitAlgoBase.h" | ||
| #include "FWCore/MessageLogger/interface/MessageLogger.h" | ||
|
|
||
| class BTLUncalibRecHitAlgo : public BTLUncalibratedRecHitAlgoBase { | ||
| public: | ||
| /// Constructor | ||
| BTLUncalibRecHitAlgo( const edm::ParameterSet& conf, | ||
| edm::ConsumesCollector& sumes ) : | ||
| MTDUncalibratedRecHitAlgoBase<BTLDataFrame>( conf, sumes ), | ||
| adcNBits_( conf.getParameter<uint32_t>("adcNbits") ), | ||
| adcSaturation_( conf.getParameter<double>("adcSaturation") ), | ||
| adcLSB_( adcSaturation_/(1<<adcNBits_) ), | ||
| toaLSBToNS_( conf.getParameter<double>("toaLSB_ns") ), | ||
| timeError_( conf.getParameter<double>("timeResolutionInNs") ), | ||
| timeCorr_p0_( conf.getParameter<double>("timeCorr_p0") ), | ||
| timeCorr_p1_( conf.getParameter<double>("timeCorr_p1") ), | ||
| timeCorr_p2_( conf.getParameter<double>("timeCorr_p2") ) | ||
| { } | ||
|
|
||
| /// Destructor | ||
| ~BTLUncalibRecHitAlgo() override { } | ||
|
|
||
| /// get event and eventsetup information | ||
| void getEvent(const edm::Event&) final {} | ||
| void getEventSetup(const edm::EventSetup&) final {} | ||
|
|
||
| /// make the rec hit | ||
| FTLUncalibratedRecHit makeRecHit(const BTLDataFrame& dataFrame ) const final; | ||
|
|
||
| private: | ||
|
|
||
| const uint32_t adcNBits_; | ||
| const double adcSaturation_; | ||
| const double adcLSB_; | ||
| const double toaLSBToNS_; | ||
| const double timeError_; | ||
| const double timeCorr_p0_; | ||
| const double timeCorr_p1_; | ||
| const double timeCorr_p2_; | ||
|
|
||
| }; | ||
|
|
||
| FTLUncalibratedRecHit | ||
| BTLUncalibRecHitAlgo::makeRecHit(const BTLDataFrame& dataFrame ) const { | ||
| constexpr int iSample=2; //only in-time sample | ||
| const auto& sample = dataFrame.sample(iSample); | ||
|
|
||
| double amplitude = double(sample.data()) * adcLSB_; | ||
| double time = double(sample.toa()) * toaLSBToNS_; | ||
|
|
||
| // --- Correct the time for the time-walk and the constant delays | ||
| if ( amplitude > 0. ) | ||
| time -= timeCorr_p0_*pow(amplitude,timeCorr_p1_) + timeCorr_p2_; | ||
|
|
||
| unsigned char flag = 0; | ||
|
|
||
| LogDebug("BTLUncalibRecHit") << "ADC+: set the charge to: " << amplitude << ' ' << sample.data() | ||
| << ' ' << adcLSB_ << ' ' << std::endl; | ||
| LogDebug("BTLUncalibRecHit") << "ADC+: set the time to: " << time << ' ' << sample.toa() | ||
| << ' ' << toaLSBToNS_ << ' ' << std::endl; | ||
| LogDebug("BTLUncalibRecHit") << "Final uncalibrated amplitude : " << amplitude << std::endl; | ||
|
|
||
| return FTLUncalibratedRecHit( dataFrame.id(), amplitude, time, timeError_, flag); | ||
| } | ||
|
|
||
| #include "FWCore/Framework/interface/MakerMacros.h" | ||
| DEFINE_EDM_PLUGIN( BTLUncalibratedRecHitAlgoFactory, BTLUncalibRecHitAlgo, "BTLUncalibRecHitAlgo" ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| #include "RecoLocalFastTime/FTLCommonAlgos/interface/MTDUncalibratedRecHitAlgoBase.h" | ||
| #include "FWCore/MessageLogger/interface/MessageLogger.h" | ||
|
|
||
| class ETLUncalibRecHitAlgo : public ETLUncalibratedRecHitAlgoBase { | ||
| public: | ||
| /// Constructor | ||
| ETLUncalibRecHitAlgo( const edm::ParameterSet& conf, | ||
| edm::ConsumesCollector& sumes ) : | ||
| MTDUncalibratedRecHitAlgoBase<ETLDataFrame>( conf, sumes ), | ||
| adcNBits_( conf.getParameter<uint32_t>("adcNbits") ), | ||
| adcSaturation_( conf.getParameter<double>("adcSaturation") ), | ||
| adcLSB_( adcSaturation_/(1<<adcNBits_) ), | ||
| toaLSBToNS_( conf.getParameter<double>("toaLSB_ns") ), | ||
| tofDelay_( conf.getParameter<double>("tofDelay") ), | ||
| timeError_( conf.getParameter<double>("timeResolutionInNs") ) | ||
| { } | ||
|
|
||
| /// Destructor | ||
| ~ETLUncalibRecHitAlgo() override { } | ||
|
|
||
| /// get event and eventsetup information | ||
| void getEvent(const edm::Event&) final {} | ||
| void getEventSetup(const edm::EventSetup&) final {} | ||
|
|
||
| /// make the rec hit | ||
| FTLUncalibratedRecHit makeRecHit(const ETLDataFrame& dataFrame ) const final; | ||
|
|
||
| private: | ||
|
|
||
| const uint32_t adcNBits_; | ||
| const double adcSaturation_; | ||
| const double adcLSB_; | ||
| const double toaLSBToNS_; | ||
| const double tofDelay_; | ||
| const double timeError_; | ||
|
|
||
| }; | ||
|
|
||
| FTLUncalibratedRecHit | ||
| ETLUncalibRecHitAlgo::makeRecHit(const ETLDataFrame& dataFrame ) const { | ||
| constexpr int iSample=2; //only in-time sample | ||
| const auto& sample = dataFrame.sample(iSample); | ||
|
|
||
| double amplitude = double(sample.data()) * adcLSB_; | ||
| double time = double(sample.toa()) * toaLSBToNS_ - tofDelay_; | ||
| unsigned char flag = 0; | ||
|
|
||
| LogDebug("ETLUncalibRecHit") << "ADC+: set the charge to: " << amplitude << ' ' << sample.data() | ||
| << ' ' << adcLSB_ << ' ' << std::endl; | ||
| LogDebug("ETLUncalibRecHit") << "ADC+: set the time to: " << time << ' ' << sample.toa() | ||
| << ' ' << toaLSBToNS_ << ' ' << std::endl; | ||
| LogDebug("ETLUncalibRecHit") << "Final uncalibrated amplitude : " << amplitude << std::endl; | ||
|
|
||
| return FTLUncalibratedRecHit( dataFrame.id(), amplitude, time, timeError_, flag); | ||
| } | ||
|
|
||
| #include "FWCore/Framework/interface/MakerMacros.h" | ||
| DEFINE_EDM_PLUGIN( ETLUncalibratedRecHitAlgoFactory, ETLUncalibRecHitAlgo, "ETLUncalibRecHitAlgo" ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #include "RecoLocalFastTime/FTLCommonAlgos/interface/MTDUncalibratedRecHitAlgoBase.h" | ||
|
|
||
| EDM_REGISTER_PLUGINFACTORY(BTLUncalibratedRecHitAlgoFactory, "BTLUncalibratedRecHitAlgoFactory"); | ||
| EDM_REGISTER_PLUGINFACTORY(ETLUncalibratedRecHitAlgoFactory, "ETLUncalibratedRecHitAlgoFactory"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be better to define these parameters in a common place and pick them up from that one place by the digitizer and reco.
What is the plan to put all these calibration constants in the DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan is to put all the calibration constants in the DB. For what concerns the hardware specs, like the number of ADC bits, TDC bits, there range and so on, once the hardware is defined, I think I will follow the example of the other systems .