Change how we calculate GUID #24262
Change how we calculate GUID #24262
Conversation
Previously, we used uuid_generate_time which used the MAC address of the machine as part of the calculation. This is leading to problems when we run on virtual machines as many of the machines share the same dummy MAC address. This has lead to noticeable GUID collisions in production. By switching to uuid_generate_random, we hope to decrease collisions.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_10_2_X. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
backport #24246 |
|
Thanks! |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Previously, we used uuid_generate_time which used the MAC address of the machine as part of the calculation. This is leading to problems when we run on virtual machines as many of the machines share the same dummy MAC address. This has lead to noticeable GUID collisions in production. By switching to uuid_generate_random, we hope to decrease collisions.