DD Name Cleanup #24313
DD Name Cleanup #24313
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24313/6055 |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/Core @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @alja, @jfernan2, @kpedro88, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
|
||
| //! \b don't \b use \b! | ||
| virtual int id() const=0; // dont't know if usefull ... | ||
| static Registry::iterator registerName( const std::pair<std::string, std::string> & s ); |
There was a problem hiding this comment.
Instead of returning an iterator, which implies one could move forward, why not just return the std::pair<>?
|
+1 |
|
+1 |
| (( myDDLRotation->size() > 0) ? myDDLRotation->getDDName( nmspace ) : | ||
| (( myDDLRefl->size() > 0) ? myDDLRefl->getDDName(nmspace) : | ||
| (( myrRefl->size() > 0 ) ? myrRefl->getDDName(nmspace) : DDName(""))))); | ||
| // if (myrRotation->size() > 0){ |
There was a problem hiding this comment.
delete commented-out code
| if (mip.isDefined().first == nullptr) { | ||
| err=true; | ||
| curr_err += "material not declared; unknown material!"; | ||
| //edm::LogError("DDCheckMaterials") << "material not declared!" << std::endl; //exit(1); |
There was a problem hiding this comment.
delete commented-out code
|
|
||
| // recursive checking of constituents | ||
| // the composite material is not ok if only one constituent is not ok | ||
| int loop = mp.noOfConstituents() - 1; |
There was a problem hiding this comment.
why does this need to be declared outside of the loop condition?
|
please also consider the earlier comment: #24313 (comment) |
|
@kpedro88 - duly noted. Thanks. |
|
+upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
+1 |
@Dr15Jones and @cvuosalo - I'd like to rewrite DDName class. Perhaps, to drop the need for singletons and replace the search on the DDname's id using is_transparent?
@cvuosalo - FYI, there are way to many string copies done unnecessarily in the algorithms.
Note: this is based on #24263