Egamma710

[d4space]

EgammaCutBasedEleId::PassWP(...., ElectronEffectiveArea::ElectronEffectiveAreaTarget): adding an argument to select a EffectiveArea Version

[cmsbuild]

A new Pull Request was created by @d4space for CMSSW_7_1_X.

Egamma710

It involves the following packages:

EgammaAnalysis/ElectronTools

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[vadler]

@d4space : You have moved the hard-coding from one C++ code to the other, but it is not turned into a config parameter (of EGammaCutBasedEleIdAnalyzer) yet. I can point you to examples, how to pass enums as strings, if needed (ask via hn-cms-physTools@cern.ch in that case).
BTW: You do not need to create a new PR; updating (pushing to the same topic branch) is fine and keeps the discussion in its context.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2428/168/summary.html

[monttj]

EGammaCutBasedEleIdAnalyzer is just example analyzer. It is analyzer's choice whether or not having config parameter. So I think it is OK just to provide a function with the option that can point to which effective area should be used.

[cmsbuild]

Pull request #2428 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

[d4space]

Dear,

I’ve updated Feb 13, making EleEA option configurable.
But i’ve just see this updated pull request now.
I wonder why this happen.

Thanks,
SangEun
On Feb 18, 2014, at 5:38 PM, cmsbuild notifications@github.com wrote:

Pull request #2428 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

—
Reply to this email directly or view it on GitHub.

[monttj]

+1
runtests is done.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2428/223/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[vadler]

@d4space : Will this be ported to #2376 ?