Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates to L3 Muon OI SeedGenerator for high efficiency ( Backport PR for #24267 ) #24324

Merged
merged 1 commit into from Aug 31, 2018

Conversation

bmahakud
Copy link
Contributor

Backport for PR #24267
Major updates to HLT OI reconstruction. No changes made to customizeHLTforCMSSW.py. Only .cc file changes

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2018

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for CMSSW_10_1_X.

It involves the following packages:

RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @folguera, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bmahakud
Copy link
Contributor Author

@Martin-Grunewald Backport PR

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29897/console Started: 2018/08/17 12:30

@perrotta
Copy link
Contributor

@bmahakud : please update the title to match the one of the backported pull request (so that one can understand from it what this PR deals with)

@perrotta
Copy link
Contributor

backport of #24267

@bmahakud bmahakud changed the title backport PR 10_1_x backport of #24267 (10_1_X) Aug 17, 2018
@bmahakud bmahakud changed the title backport of #24267 (10_1_X) Backport of #24267 (10_1_X) Aug 17, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24324/29897/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2520647
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2520470
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@perrotta
Copy link
Contributor

+1

  • New plugin added for a new L3 Muon OI SeedGenerator meant to higher efficiency than the current one
  • Wrt the backported PR, here the plugin is not automatically replaced to the old one in the HLT menu
    . Jenkins tests pass, with no effect on reco quantities

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

Needs fix #24342 to be included here as well!

@Martin-Grunewald
Copy link
Contributor

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@Martin-Grunewald,@silviodonato,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Martin-Grunewald
Copy link
Contributor

Fix not needed here as we only add the new plugin.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@bmahakud bmahakud changed the title Backport of #24267 (10_1_X) Major updates to L3 Muon OI SeedGenerator for high efficiency ( Backport PR for #24267 ) Aug 20, 2018
@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3e46cb into cms-sw:CMSSW_10_1_X Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants