Implimentation of Dual-Slope signal scaling for the Inner Pixel #24325

suchandradutta · 2018-08-17T10:41:30Z

Updating Phase2TrackerDigitizerAlgorithm with the option of dual slope scaling of signal to be used for the inner pixel detector. A new monitoring histogram added in one of the analyzers in the validation suite (Phase2TrackerMonitorDigi).

The update was present in the Phase2 tracker simulation meeting
https://indico.cern.ch/event/688845/contributions/3026531/attachments/1660515/2660028/DualSlopeCorrection_May30.pdf

NB: There will be a similar PR for the Phase2 clusterizer both these PRs should be included together

@emiglior @avartak @boudoul

…e scaling of signal to be used for the inner pixel detector. A new monitoinghistogram added in the analyzer Phase2TrackerMonitorDigi

…hreshold subtraction and keeping the TDR option with a specific value of the flag

cmsbuild · 2018-08-17T10:41:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-08-17T10:44:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24325/6070

cmsbuild · 2018-08-17T10:44:30Z

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

SimTracker/SiPhase2Digitizer

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

civanch · 2018-08-20T14:51:16Z

please test

cmsbuild · 2018-08-20T14:51:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29929/console Started: 2018/08/20 16:52

cmsbuild · 2018-08-20T17:07:16Z

-1

Tested at: 702fda5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24325/29929/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

cmsbuild · 2018-08-20T17:07:18Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

kpedro88 · 2018-08-20T21:11:05Z

20-Aug-2018 17:56:03 CEST  Initiating request to open file file:step1.root
20-Aug-2018 17:56:04 CEST  Successfully opened file file:step1.root
20-Aug-2018 17:56:06 CEST  Closed file file:step1.root
----- Begin Fatal Exception 20-Aug-2018 17:56:06 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'ReadoutMode' not found.
----- End Fatal Exception -------------------------------------------------

kpedro88 · 2018-08-20T21:11:27Z

SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.cc

+      temp_signal = std::floor(signal_in_elec / theElectronPerADC) + 1;
+    } else {
+      // calculate the kink point and the slope
+      const int dualslope_param = std::min(abs(thePhase2ReadoutMode), 10);


make a named constant for magic number 10

kpedro88 · 2018-08-20T21:11:52Z

SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h

@@ -116,7 +116,7 @@ class Phase2TrackerDigitizerAlgorithm  {
  const float ClusterWidth;       // Gaussian charge cutoff width in sigma units

  //-- make_digis 
-  const bool doDigitalReadout;        //  Flag to decide analog or digital readout
+  const int   thePhase2ReadoutMode;  //  Flag to decide readout mode (digital/Analong dual slope etc.)


analong -> analog

kpedro88 · 2018-08-20T21:12:48Z

SimTracker/SiPhase2Digitizer/test/Phase2TrackerMonitorDigi.cc

 	} else {
          position /= width;  
          local_mes.ClusterWidth->Fill(width);
          local_mes.ClusterPosition->Fill(position);
+	  for (std::vector<int>::iterator ic = charges.begin(); ic != charges.end(); ic++) local_mes.ChargeOfDigisVsWidth->Fill((*ic), width);


use range-based loop

cmsbuild · 2018-09-06T05:28:22Z

Pull request #24325 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again.

emiglior · 2018-09-06T07:44:02Z

please test

civanch · 2018-09-06T17:24:46Z

please test

cmsbuild · 2018-09-06T17:25:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30286/console Started: 2018/09/06 19:26

cmsbuild · 2018-09-06T18:30:19Z

+1
Tested at: 61b50f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24325/30286/summary.html

cmsbuild · 2018-09-06T18:30:23Z

Comparison job queued.

cmsbuild · 2018-09-06T19:47:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24325/30286/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1418 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3143975
DQMHistoTests: Total failures: 1141
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3142637
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

emiglior · 2018-09-06T21:07:47Z

Screenshots of a dEdx distribution in the previous version of the PR [1] and in the new version of the PR [2]. In the new PR the differences wrt baseline are much reduced a part from small (expected) differences in the tail (we have slightly modified the max value of one parameter).

[1]
[2]

kpedro88 · 2018-09-06T21:30:25Z

+upgrade

civanch · 2018-09-07T17:40:18Z

+1

cmsbuild · 2018-09-07T17:40:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-09-08T15:33:44Z

+1

Suchandra added 2 commits August 9, 2018 13:40

Updating Phase2TrackerDigitizerAlgorithm with the option of dual slop…

5338dfd

…e scaling of signal to be used for the inner pixel detector. A new monitoinghistogram added in the analyzer Phase2TrackerMonitorDigi

Allowed values for the dual slope parameters updated to enforce the t…

702fda5

…hreshold subtraction and keeping the TDR option with a specific value of the flag

cmsbuild added this to the CMSSW_10_3_X milestone Aug 17, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Aug 17, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 17, 2018

avartak mentioned this pull request Aug 17, 2018

Implementation of the dual slope in the clusterizer for Phase2 IT #24329

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 20, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 20, 2018

kpedro88 reviewed Aug 20, 2018

View reviewed changes

Bug fix

9effc37

cmsbuild removed the code-checks-approved label Aug 24, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 6, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 6, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 6, 2018

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Sep 7, 2018

cmsbuild added orp-approved and removed orp-pending labels Sep 8, 2018

cmsbuild merged commit bb1351d into cms-sw:master Sep 8, 2018

emiglior mentioned this pull request Sep 14, 2018

clean up SiPixel digitizer and clusterizer code removing variables used for pre-phase2 TDR studies #24546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implimentation of Dual-Slope signal scaling for the Inner Pixel #24325

Implimentation of Dual-Slope signal scaling for the Inner Pixel #24325

suchandradutta commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

civanch commented Aug 20, 2018

cmsbuild commented Aug 20, 2018 •

edited

cmsbuild commented Aug 20, 2018

cmsbuild commented Aug 20, 2018

kpedro88 commented Aug 20, 2018

kpedro88 Aug 20, 2018

kpedro88 Aug 20, 2018

kpedro88 Aug 20, 2018

cmsbuild commented Sep 6, 2018

emiglior commented Sep 6, 2018

civanch commented Sep 6, 2018

cmsbuild commented Sep 6, 2018 •

edited

cmsbuild commented Sep 6, 2018

cmsbuild commented Sep 6, 2018

cmsbuild commented Sep 6, 2018

emiglior commented Sep 6, 2018

kpedro88 commented Sep 6, 2018

civanch commented Sep 7, 2018

cmsbuild commented Sep 7, 2018

fabiocos commented Sep 8, 2018

Implimentation of Dual-Slope signal scaling for the Inner Pixel #24325

Implimentation of Dual-Slope signal scaling for the Inner Pixel #24325

Conversation

suchandradutta commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

cmsbuild commented Aug 17, 2018

civanch commented Aug 20, 2018

cmsbuild commented Aug 20, 2018 • edited

cmsbuild commented Aug 20, 2018

cmsbuild commented Aug 20, 2018

kpedro88 commented Aug 20, 2018

kpedro88 Aug 20, 2018

Choose a reason for hiding this comment

kpedro88 Aug 20, 2018

Choose a reason for hiding this comment

kpedro88 Aug 20, 2018

Choose a reason for hiding this comment

cmsbuild commented Sep 6, 2018

emiglior commented Sep 6, 2018

civanch commented Sep 6, 2018

cmsbuild commented Sep 6, 2018 • edited

cmsbuild commented Sep 6, 2018

cmsbuild commented Sep 6, 2018

cmsbuild commented Sep 6, 2018

emiglior commented Sep 6, 2018

kpedro88 commented Sep 6, 2018

civanch commented Sep 7, 2018

cmsbuild commented Sep 7, 2018

fabiocos commented Sep 8, 2018

cmsbuild commented Aug 20, 2018 •

edited

cmsbuild commented Sep 6, 2018 •

edited