Make L1T object comparison fillDescriptions compatible with ConfDB parsing - 101x

[thomreis]

Backport of #24372

In order to have the framework modules appear in the ConfDB GUI it is needed to replace object comparison and filter fillDescriptions addDefault with addWithDefaultLabel.

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_1_X.

It involves the following packages:

L1Trigger/L1TCommon

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Make L1T object comparison fillDescriptions compatible with ConfDB parsing #24372

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29998/console Started: 2018/08/23 11:52

[cmsbuild]

+1
Tested at: ee1c104
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24374/29998/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24374/29998/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 681 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2483882
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2483714
• DQMHistoTests: Total skipped: 167
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
• Checked 116 log files, 9 edm output root files, 28 DQM output files

[Martin-Grunewald]

assign hlt

[Martin-Grunewald]

-1

[cmsbuild]

New categories assigned: hlt

@Martin-Grunewald,@silviodonato,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

Pull request #24374 was updated. @cmsbuild, @Martin-Grunewald, @silviodonato, @nsmith-, @rekovic, @thomreis, @fwyzard can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30014/console Started: 2018/08/23 17:21

[Martin-Grunewald]

+1

[cmsbuild]

+1
Tested at: 88caa5d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24374/30014/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24374/30014/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2520647
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2520470
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1