CLCTs are offset by 1 BX in matching

[dildick]

Recent data vs emulator studies using 2018C data (in particular data from the ME+1/1/9 OTMB) have shown that the CLCT BX are not shifted in the ALCT-CLCT matching algorithms. They are shifted when the CLCTs are written to EDM ROOT files however. Because the ALCT-CLCT matching windows are quite wide (7BX) in the current CSC local trigger firmware and emulator, it has a negligible effect. However, it does start playing a role when the ALCT-CLCT matching window is reduced to 5BX and ultimately 3BX. That is foreseen in the "SLHC" version of the CSC local trigger.

In addition, the matching algorithm type was changed from CLCT-centric to ALCT-centric. This as always been the case in firmware.

A redundant test TMB run function was also removed.

This PR addresses these issues.

@tahuang1991 @lpernie @ptcox

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24402/6199

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[tahuang1991]

around 2009, Several similar lines were added to the ALCT-CLCT matching part in CSC emulator

if (!isSLHC) bx_alct_stop += match_trig_window_size%2;

What it did is extend the ALCT-CLCT matching window by a half of window size and at that time, because there is 1BX offset between wire digi timing and comparator digi timing from data and it results in 1BX offset in re-emulated ALCTs and CLCTs. I guess, as a temporary solution to this offset saw by ALCT-CLCt matching in CSC emulator, the matching window is extended in this "ulgy" way. And now when we turned on isSLCH flag, we found that the window was not extended and the issue was uncovered. What we really should do about it is to add ALCT-CLCT bx offset also in the matching part in CSC emulator. In our previous changes about timing shift, we only shift the BX of ALCT and CLCT in read-out part, not in matching part.

As for another change, ALCT-centric is enabled because in (O)TMB fw, it is always the case. But it may not have any visible effect on offline re-emulation and MC. It is quite important for (O)TMB fw to use ALCT-centric because ALCT has better timing and LCT timing is referred to ALCT timing, in other word, LCT is always built and sent out with fixed latency relative to ALCT timing

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30108/console Started: 2018/08/28 23:37

[cmsbuild]

+1
Tested at: 38410a3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24402/30108/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24402/30108/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3143859
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3143660
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[dildick]

@thomreis Could you sign, please? Thanks.

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1