Pr103x HeavyIon 2018 CaloLayer2, Un/Packer, Emulator, O2O #24569

rekovic · 2018-09-17T18:21:18Z

PR 10_3_X

EtSum type algorithms designed for HeavyIon 2018 data taking.

kTowerCount,
kCentrality,
kAsymEt,
kAsymHt,
kAsymEtHF,
kAsymHtHF
are implemented in CaloLayer2 subsystem of the L1 trigger.

Changes are made in the CaloLayer

Unpacker,
Packer,
Emulator,
O2O online producer

This PR does not depend on the updated UTM library, and can be merged independently.

However, this PR is needed merged for a PR on GlobalTrigger (#24570) to be tested, which in turn
also depends on the new UTM library v 0.7.1 (cms-sw/cmsdist#4338).

… Modernizing L1Trigger/L1TCalorimeter.

rekovic · 2018-09-17T18:21:52Z

please test

cmsbuild · 2018-09-17T18:23:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-17T18:27:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24569/6457

cmsbuild · 2018-09-17T18:27:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30465/console Started: 2018/09/17 20:27

cmsbuild · 2018-09-17T18:27:26Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DataFormats/L1Trigger
EventFilter/L1TRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TNtuples
L1TriggerConfig/L1TConfigProducers

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-09-17T22:04:25Z

-1

Tested at: 9cb56ca

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24569/30465/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step2_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

136.85 step2

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

150.0 step2

runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/step2_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsbuild · 2018-09-17T22:04:28Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-09-18T07:52:57Z

The code-checks are being triggered in jenkins.

rekovic · 2018-09-18T07:52:59Z

please test

cmsbuild · 2018-09-18T07:55:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24569/6464

cmsbuild · 2018-09-18T07:55:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30473/console Started: 2018/09/18 09:57

cmsbuild · 2018-09-18T07:55:48Z

Pull request #24569 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

rekovic · 2018-09-18T09:54:42Z

+1

cmsbuild · 2018-09-18T09:55:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-09-18T11:41:27Z

+1
Tested at: 6cfadd3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24569/30473/summary.html

cmsbuild · 2018-09-18T11:41:30Z

Comparison job queued.

cmsbuild · 2018-09-18T13:21:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24569/30473/summary.html

The workflows 4.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2681819
DQMHistoTests: Total failures: 47
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2681602
DQMHistoTests: Total skipped: 170
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
Checked 119 log files, 10 edm output root files, 32 DQM output files

fabiocos · 2018-09-19T13:09:43Z

@rekovic as far as I can see from comparisons, they are not affecting only HI workflows but also regular pp ones. Could you please confirm that this is intended?

rekovic · 2018-09-20T11:37:57Z

@fabiocos
There are new added types EtSums for Hi in the DataFormat, but not meaningful for p-p. They will be available in every wf that emulates Calo, also wf's with packer and unpacker, . Can you please point me to a DQM plot that you might be referring to? Thx.

fabiocos · 2018-09-23T10:46:55Z

@rekovic you may check failed comparisons for wfs 10024, 10224, 10042 for instance...

fabiocos · 2018-09-25T08:11:10Z

+1

checking with @rekovic just additional information is added with no modification to the existing one

bundocka and others added 6 commits September 17, 2018 08:54

Implement new EtSum types and version EtSumUnpacker for Heavy Ion 2018

fbe9459

HI update

24e77a9

Add fw divide to calotools and demux sums emu

62b6110

Update HI dev, add HI caloParams

93fd910

Put back member variable removed in CMSSW master in one of the PRs of…

64b120a

… Modernizing L1Trigger/L1TCalorimeter.

Code-checks updates.

9cb56ca

cmsbuild added this to the CMSSW_10_3_X milestone Sep 17, 2018

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Sep 17, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 17, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 17, 2018

rekovic mentioned this pull request Sep 17, 2018

Pr103x hi 2018 uGT #24570

Merged

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Sep 17, 2018

rekovic mentioned this pull request Sep 18, 2018

CaloLayer2 for HI failing integration tests in CMSSW_10_3_X cms-l1t-offline/cmssw#722

Closed

cmsbuild added the tests-pending label Sep 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 18, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 18, 2018

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Sep 18, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 18, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 18, 2018

cmsbuild added orp-approved and removed orp-pending labels Sep 25, 2018

cmsbuild merged commit af31d55 into cms-sw:master Sep 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr103x HeavyIon 2018 CaloLayer2, Un/Packer, Emulator, O2O #24569

Pr103x HeavyIon 2018 CaloLayer2, Un/Packer, Emulator, O2O #24569

rekovic commented Sep 17, 2018 •

edited

rekovic commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018 •

edited

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 18, 2018

rekovic commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018 •

edited

cmsbuild commented Sep 18, 2018

rekovic commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

fabiocos commented Sep 19, 2018

rekovic commented Sep 20, 2018

fabiocos commented Sep 23, 2018

fabiocos commented Sep 25, 2018

Pr103x HeavyIon 2018 CaloLayer2, Un/Packer, Emulator, O2O #24569

Pr103x HeavyIon 2018 CaloLayer2, Un/Packer, Emulator, O2O #24569

Conversation

rekovic commented Sep 17, 2018 • edited

rekovic commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018 • edited

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 18, 2018

rekovic commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018 • edited

cmsbuild commented Sep 18, 2018

rekovic commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

fabiocos commented Sep 19, 2018

rekovic commented Sep 20, 2018

fabiocos commented Sep 23, 2018

fabiocos commented Sep 25, 2018

rekovic commented Sep 17, 2018 •

edited

cmsbuild commented Sep 17, 2018 •

edited

cmsbuild commented Sep 18, 2018 •

edited