Pr103x hi 2018 uGT #24570
Pr103x hi 2018 uGT #24570
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24570/6460 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24570/6460/git-diff.patch You can run |
|
@rekovic please check the suggested fix |
|
@fabiocos |
|
please test with #24569 |
|
some impressive cascades of if statements;)
you might confirm that this code compiles, often not compiling is a reason for clang-tidy to do something strange.likely the new utm library was not available?
… On Sep 18, 2018, at 11:51 AM, rekovic ***@***.***> wrote:
@fabiocos
I am not sure about the suggested fix.
Is there any way we can test this PR as is?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 Thanks. The new UTM library should be in the IB from last night at 0000. In which log can I check against which version of IB is this PR being tested? |
|
so it would have required a time machine in this case. You can see from the logs what was done.
… On Sep 18, 2018, at 12:10 PM, rekovic ***@***.***> wrote:
@davidlange6 Thanks.
The new UTM library should be in the IB from last night at 0000.
cms-sw/cmsdist#4338
In which log can I check against which version of IB is this PR being tested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
code-checks
… On Sep 18, 2018, at 12:10 PM, rekovic ***@***.***> wrote:
@davidlange6 Thanks.
The new UTM library should be in the IB from last night at 0000.
cms-sw/cmsdist#4338
In which log can I check against which version of IB is this PR being tested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24570/6465 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24570/6465/git-diff.patch You can run |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 after properly accounting for the merge of #24569 the tests are finally positive |
PR 10_3_X
HeavyIon 2018 updates for the uGT emulator.
This PR takes advantage of HeavyIon developments in CaloLayer2 emulator (#24569)
and the UTM library v 0.7.1 (external cms-sw/cmsdist#4338) which provides the interface b/w the L1TMenu xml and this uGT emulator.
Both are needed for this PR to successfully test.