BMTF-KMTF DQM Algo Selector for the DQM/L1TMonitor Subsystem + SEGFAULT fix

[panoskatsoulis]

This is the introduction of a new DQM plugin that selects the correct output muons of the BMTF depending on the algorithm that is triggering (Kalman BMTF/ Legacy BMTF).
Also, the PR includes the last BMTF Unpacker which is required by the DQM workflow and by the L1TBMTFAlgoSelector to operate correctly

Also:

1. Here is fixed the SEGFAULT that occurred at some workflows.
2. A minor change to the Unpacker for a problem that illustrated by the last weekend's tests.

[cmsbuild]

A new Pull Request was created by @panoskatsoulis for CMSSW_10_2_X.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30657/console Started: 2018/09/26 17:32

[andrius-k]

Hi @panoskatsoulis, is this a backport of two previous PRs? If so could you please mark it as so?

[cmsbuild]

+1
Tested at: ec47ccd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24660/30657/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24660/30657/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2986038
• DQMHistoTests: Total failures: 22
• DQMHistoTests: Total nulls: 32
• DQMHistoTests: Total successes: 2985794
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 92.302 KiB( 30 files compared)
• DQMHistoSizes: changed ( 136.788,... ): 4.359 KiB L1TEMU/L1TdeStage2BMTF
• DQMHistoSizes: changed ( 136.788,... ): 2.233 KiB L1T/L1TStage2BMTF
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[thomreis]

Hi @panoskatsoulis
is this a backport of PRs to the master branch? If not please make a PR of this to the master and flag this as a backport PR of if.

[panoskatsoulis]

backport of #24652
This PR includes code of #24237 and #24555

[panoskatsoulis]

A new PR that is compatible with tag 10.2.5 has been created
#24793
This will be closed