BMTF-KMTF DQM Algo Selector for the DQM/L1TMonitor Subsystem + SEGFAULT fix

[panoskatsoulis]

This is the introduction of a new DQM plugin that selects the correct output muons of the BMTF depending on the algorithm that is triggering (Kalman BMTF/ Legacy BMTF).
Also, the PR includes the last BMTF Unpacker which is required by the DQM workflow and by the L1TBMTFAlgoSelector to operate correctly

(This is a rebasment of #24660 to make it compatible with v10.2.5)

Also:

1. Here is fixed the SEGFAULT that occurred at some workflows.
2. A minor change to the Unpacker for a problem that illustrated by the last weekend's tests.

backport of #24652
This PR includes code of #24237 and #24555

[cmsbuild]

A new Pull Request was created by @panoskatsoulis for CMSSW_10_2_X.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from BMTF fixes for the AlgoSelector and the Unpacker #24652

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30867/console Started: 2018/10/03 08:22

[thomreis]

backport of #24652
This PR includes code of #24237 and #24555

[cmsbuild]

+1
Tested at: bbe3b74
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24793/30867/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24793/30867/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2604983
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 25
• DQMHistoTests: Total successes: 2604790
• DQMHistoTests: Total skipped: 167
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 72.523 KiB( 27 files compared)
• DQMHistoSizes: changed ( 10042.0,... ): 4.359 KiB L1TEMU/L1TdeStage2BMTF
• DQMHistoSizes: changed ( 10042.0,... ): 2.233 KiB L1T/L1TStage2BMTF
• Checked 120 log files, 14 edm output root files, 28 DQM output files

[andrius-k]

+1

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[andrius-k]

Hi @panoskatsoulis, as 10_2 is no longer being used maybe this PR should be closed?

[panoskatsoulis]

Hi @andrius-k, yes it can be closed.