Changes to get tests 3400 and 15001 to use the correct customisation for harvesting

[mark-grimes]

Spot fix to use the correct customisation for harvesting in test 3400 and 15001. Will also affect all 34xx and 15101, 16001, 17001, 17011, 18001, 18101, 19001 and 19101.

This is a short term fix while testing pull requests for SLHC8. After then the matrix test declaration will be changed to be more flexible.

Tested 3400 and 15001 which now pass all steps (previously failed at step 4).
Also tested 3300, 4100, 4400, 40001, 50002, 60002, 60001, 4502, 4500, 5001 and 50001 (slightly pointless but it doesn't hurt to be safe). All passed except 50001 and 60001 fail in step 1 with known error; 4502 failed with 'Disk quota exceeded'. Assumed it would be fine with more space but didn't re-test.

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Changes to get tests 3400 and 15001 to use the correct customisation for harvesting

It involves the following packages:

Configuration/PyReleaseValidation

@nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

merge

I feel a bit cheeky merging my own pull request immediately, but it's to test everything else for SLHC8.
Also tested with 3400 and combinedCustoms.cust_2019WithGem.

[franzoni]

Hi Mark,
can you not run the tests you need locally ? Customise functions used in relvals and the matrix are a nightmare already, additional combinatorics of interfering custimize functions is making the night darker and darker. Please, help us keeping the validation matrix (close-to) intelligible.

The use of customize functions is something we are moving away from anyway - or we ought to at least. "epochs" are being developed as a systematised way of handling the few CMS scenarios we ought to handle specificities of.

Giovanni

[davidlange6]

Hi Giovanni

fwiw, we've revamped the upgrade part of runTheMatrix to make the management of the trio of geometry,gt,customization quite straightforward. Hopefully that work will get into SLHC8. Eg, the problem Mark is fixing is a simple cut and paste mistake that should soon be reduced to a minimum.

Cheers-
david

On Feb 14, 2014, at 2:02 PM, franzoni notifications@github.com
wrote:

Hi Mark,
can you not run the tests you need locally ? Customise functions used in relvals and the matrix are a nightmare already, additional combinatorics of interfering custimize functions is making the night darker and darker. Please, help us keeping the validation matrix (close-to) intelligible.

The use of customize functions is something we are moving away from anyway - or we ought to at least. "epochs" are being developed as a systematised way of handling the few CMS scenarios we ought to handle specificities of.

Giovanni

—
Reply to this email directly or view it on GitHub.

[mark-grimes]

Hi,
I thought it would be better than running locally because @andersonjacob (and others) will be running the tests as well. Admittedly they could use a branch of mine but the main reason was to fix the tests for the cmsbuild bot.
David Lange has written a much better long term fix that I intend to go through and hopefully put in by the start of next week. This was just intended as a short term (day or two) fix to clear the current pull requests.