Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mixing scenario for PU250 and PU300 #24821

Merged
merged 1 commit into from Oct 9, 2018

Conversation

siddhesh86
Copy link
Contributor

Added mixing scenaring AVE_250_BX_25ns and AVE_300_BX_25ns for PU250, PU300 in Configuration/StandardSequences/python/Mixing.py with CMSSW_10_3_X. I want this change to backport to CMSSW_9_3_7.
Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2018

A new Pull Request was created by @siddhesh86 for master.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30925/console Started: 2018/10/08 16:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24821/30925/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162781
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Oct 9, 2018

@siddhesh86
Do we have a back port to 93X?

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2018

@rekovic see #24808

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

+operations

simple addition of new PU scenarios

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

+1

@cmsbuild cmsbuild merged commit 92b341b into cms-sw:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants