[10_3_X] SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes)

[pieterdavid]

Backport of #24812
As mentioned in the original PR, this fixes a bug that only affects specific studies where the patch can be applied on top of the release - but since these are most notably @CesarBernardes ' hybrid mode studies, and 10_3_X will be used for HI data taking (and therefore possibly also for future HI studies), it may be good to have it included anyway.

CC: @CesarBernardes @icali

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_10_3_X.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24812

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30976/console Started: 2018/10/11 13:34

[cmsbuild]

+1
Tested at: 773d249
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24845/30976/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24845/30976/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162780
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24845 773d249

• this is identical to SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24812 773d249, which was originally targeting 10_3_X anyways. The update affects only special [non-production] setups
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1