[10_2_X] OfflineDQM: Offline L1T muon DQM bugfix for muon resolution plots CMSLITDPG-763

[stahlleiton]

Backport of #24870

[cmsbuild]

A new Pull Request was created by @stahlleiton (Andre Stahl) for CMSSW_10_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from OfflineDQM: Offline L1T muon DQM bugfix for muon resolution plots CMSLITDPG-763 #24870

[thomreis]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31036/console Started: 2018/10/15 16:55

[cmsbuild]

-1

Tested at: fd35d2b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24874/31036/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
250202.181 step5

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step5_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[thomreis]

please test

error looks unrelated to the code changes.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31039/console Started: 2018/10/15 18:48

[cmsbuild]

+1
Tested at: fd35d2b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24874/31039/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24874/31039/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2986766
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2986569
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[andrius-k]

Hi @stahlleiton, as 10_2 is no longer being used maybe this PR should be closed?

[fabiocos]

@stahlleiton @rekovic is this PR still really needed now that 10_2_X is no more used for data taking?

[fabiocos]

hold

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fabiocos]

@rekovic @thomreis ping

[thomreis]

Hi @fabiocos
If no data is processed anymore with 10_2 this PR is not needed anymore. @stahlleiton please close it.

[fabiocos]

@thomreis pp data taking is over and for HI 10_3_X is used. Of course MC production is ongoign as well as analysis, but you do not need this for those activities, right? So I would just close it.

[thomreis]

Agreed.