Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw data remapper #24891

Merged
merged 19 commits into from Oct 17, 2018
Merged

Raw data remapper #24891

merged 19 commits into from Oct 17, 2018

Conversation

icali
Copy link
Contributor

@icali icali commented Oct 16, 2018

backport to 10_3_X of #24819

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2018

A new Pull Request was created by @icali (Ivan Amos Cali) for CMSSW_10_3_X.

It involves the following packages:

EventFilter/RawDataCollector

@mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@icali icali mentioned this pull request Oct 16, 2018
8 tasks
@fabiocos
Copy link
Contributor

please test

not really testing much

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31085/console Started: 2018/10/16 19:22

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24891/31085/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162781
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

@mommsen, @emeschi please sign the backport if it is acceptable

@mommsen
Copy link
Contributor

mommsen commented Oct 17, 2018

I think only the file 'EventFilter/RawDataCollector/src/RawDataMapperByLabel.cc' should be part of this commit. The others contain only changes to whitespace (and wrong indentation.)

@kpedro88
Copy link
Contributor

@mommsen it looks identical to the master PR to me. Perhaps the master PR could have been cleaned up more, but it is already merged.

@mommsen
Copy link
Contributor

mommsen commented Oct 17, 2018

@kpedro88, okay, I've missed it in the master PR. Not nice, but it's like that then.

@mommsen
Copy link
Contributor

mommsen commented Oct 17, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

backport of #24819

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4578967 into cms-sw:CMSSW_10_3_X Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants