Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of new iftool scram tag to conditionaly build/run tests #24904

Merged
merged 1 commit into from Oct 18, 2018
Merged

make use of new iftool scram tag to conditionaly build/run tests #24904

merged 1 commit into from Oct 18, 2018

Conversation

smuzaffar
Copy link
Contributor

This allow to build/run numba and llvmlite tests if external package exists in the env

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#4429

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4429
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31099/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24904/31099/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994644
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@smuzaffar so the tests will be run only of if the external packages are available, is this correct?

@smuzaffar
Copy link
Contributor Author

yes that is correct.

@fabiocos
Copy link
Contributor

+1

the corresponding external has been merged already, the failure in the PythonAnalysis unit test disappears

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8420a96 into cms-sw:master Oct 18, 2018
@smuzaffar smuzaffar deleted the from-CMSSW_10_4_X_2018-10-16-2300 branch October 23, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants