New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore PA skims, update HI 2018 data test workflows #25075
Conversation
…, update test data sequence adding ALCA and SKIM
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25075/7071 |
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 140.54,140.56,140.56 |
The tests are being triggered in jenkins. |
@mandrenguyen please see this update, restoring the PA skims with modified names should have no effect on the HI skims as far as I can see in my checks. |
Comparison job queued. |
+1 tests approved |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+operations |
+1 |
merge @kpedro88 in case please sign it for reference, there is nothing really relevant for the upgrade |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Following the merge of #24927 the test workflow 140.54 is failing because it is using the PA skims, that were removed. This was unfortunately missed during the scrutiny of the PR. Although the test is technical, and most likely these skims will not be reused in any close future, this PR restores them so as to minimize changes to tests and keep PA skims around for memory.
In order to avoid interferences with the new PbPb skims, the names of modules and paths are all updated adding the PA label. With this update wf 140.54 runs again.
With the occasion, the new skims are added to the 2018 HI data test workflows 140.56 and 140.57, as well as the ALCA step (as in the PPRECO tests on MC).