Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore PA skims, update HI 2018 data test workflows #25075

Merged
merged 1 commit into from Nov 1, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Oct 31, 2018

Following the merge of #24927 the test workflow 140.54 is failing because it is using the PA skims, that were removed. This was unfortunately missed during the scrutiny of the PR. Although the test is technical, and most likely these skims will not be reused in any close future, this PR restores them so as to minimize changes to tests and keep PA skims around for memory.

In order to avoid interferences with the new PbPb skims, the names of modules and paths are all updated adding the PA label. With this update wf 140.54 runs again.

With the occasion, the new skims are added to the 2018 HI data test workflows 140.56 and 140.57, as well as the ALCA step (as in the PPRECO tests on MC).

…, update test data sequence adding ALCA and SKIM
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/Skimming
Configuration/StandardSequences

@cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 140.54,140.56,140.56

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31405/console Started: 2018/10/31 17:51

@fabiocos
Copy link
Contributor Author

@mandrenguyen please see this update, restoring the PA skims with modified names should have no effect on the HI skims as far as I can see in my checks.

@fabiocos
Copy link
Contributor Author

@tocheng @lpernie I have added also ALCA to the test sequence as in the MC tests we are currently doing. Please comment in case, and suggest a possible more realistic sequence in case

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1

tests approved

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25075/31405/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25075/140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25075/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2018

+operations
a comparison of the step2 of workflow 140.56 confirms that there is no change in the PbPb skim sequence by the addition of the PA part

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2018

merge

@kpedro88 in case please sign it for reference, there is nothing really relevant for the upgrade

@cmsbuild cmsbuild merged commit a5eee45 into cms-sw:master Nov 1, 2018
@kpedro88
Copy link
Contributor

kpedro88 commented Nov 1, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants