Converted CosmicGenFilterHelix into one module

[Dr15Jones]

CosmicGenFilterHelix shows up in the integration build release validation tests. As a legacy module it was causing threading efficiency issues.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25093/7089

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31430/console Started: 2018/11/01 21:00

[Dr15Jones]

The use of TFileService from within CosmicGenFilterHelix should really be removed and put into a separate EDAnalyzer. This would allow CosmicGenFilterHelix to become a edm::stream::EDFilter or even a edm::global::EDFilter which would be much more threading efficient.

[cmsbuild]

+1
Tested at: 98bcdd7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25093/31430/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a5eee45
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25093/31430/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25093/31430/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25093/31430/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2993155
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2992956
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@efeyazgan @qliphy @alberto-sanchez please see the comment #25093 (comment) Where is this code used at present?

[qliphy]

@fabiocos Seems to be used in workflow 1307: #9469

[boudoul]

Hi @fabiocos , Tracker DPG is using this code in any major MC campaign to get Cosmic samples crucial to derive MC alignement scenario (we have once/twice per year MC cosmic campaigns) - It is also used in the WFs 7.2 and 7.4

[fabiocos]

@boudoul thank you, I was interested to understand the community using it, because I think that this community should address the comment of Chris, although it does not necessarily a top priority...

[fabiocos]

@efeyazgan @qliphy @alberto-sanchez was this validated in some way? Are you ready to sign it or do you have comments?

[efeyazgan]

GEN did not test this. Since this is used by tracker, it may be best if tracker tests this - @boudoul ? thanks.

[boudoul]

Hello , I mentioned tracker as DPG coordinator, but it's also used by Muon , GEM, tracking... well CMS is taking cosmic data every day at each interfill so CMS needs the correct cosmic generator to have the proper simulation, as any other generator . Tracker has no specific expertise in this .

[boudoul]

Since it is in runthematrix as mentioned before why the outcome of the PR/IB tests are not sufficient ?

[fabiocos]

+1

technically tested by wfs 1307 and 7.3

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.