Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCal/FW] Add support for HGCal Geom in FW #25135

Closed
wants to merge 15 commits into from

Conversation

Mourtz
Copy link
Contributor

@Mourtz Mourtz commented Nov 6, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

A new Pull Request was created by @Mourtz (Alex Mourtziapis) for master.

It involves the following packages:

.gitignore
Fireworks/Core
Fireworks/Geometry
Fireworks/SimData
Geometry/HGCalGeometry

@smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @alja, @kpedro88 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

Please remove the .gitignore file from this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 8, 2018

+upgrade
The image in #25135 (comment) looks very nice

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25135/31537/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25135/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013629
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Mourtz
Copy link
Contributor Author

Mourtz commented Nov 12, 2018

@ianna
The files that you are suggesting me to modify were merged from #25027.

@Mourtz
Copy link
Contributor Author

Mourtz commented Nov 12, 2018

@ianna
It shouldn't show any changes in those files....
Do you want me to get them out of the PR?

@Mourtz
Copy link
Contributor Author

Mourtz commented Nov 19, 2018

is there any problem with merging the PR?

@ianna
Copy link
Contributor

ianna commented Nov 19, 2018

+1

@fabiocos
Copy link
Contributor

@alja could you please check and sign it in case?

@alja
Copy link
Contributor

alja commented Nov 19, 2018

+1

1 similar comment
@alja
Copy link
Contributor

alja commented Nov 19, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@Mourtz
Copy link
Contributor Author

Mourtz commented Nov 19, 2018

changes of this PR are included in #25284. Keeping only the last PR.

@Mourtz Mourtz closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants