Re-adding 2016-2017 Cosmic WFs

[boudoul]

This branch is re-adding the 2016-2017 Cosmic WFS - The filter is the usual one : filtering within the tracker volume, so that cosmic muons can cross the entire tracker Volume (and not only the Pixel volume like in the SP case)
For 2016 I used the previous cosmic GTs defined in autocond which I believe was the one used in MC prod at that time but kept maintained: run2_mc_cosmics , but we would need the final confirmation from @lpernie and @tocheng .

WF to be tested here : 7.21 7.22 (resp 2017, 2016)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25249/7265

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31679/console Started: 2018/11/15 19:10

[fabiocos]

please test workflow 7.20,7.21,7.22

[cmsbuild]

+1
Tested at: 8dead5d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25249/31679/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25249/31679/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013094
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@slava77 this addresses your request

[fabiocos]

@lpernie @tocheng could you please confirm that the used GT here is the right one?

[lpernie]

Hello @fabiocos , this PR is pointing to the auto:run2_mc_cosmics which points to 103X_mcRun2cosmics_startup_deco_v1 in autocond.
This v1 GT, as all other 2016 GTs, has an incorrect ECAL PF threshold tag. This TAG has been fixed in #25256

[fabiocos]

@lpernie thank you, but apart for the problem that will be fixed by your additional PR the GT is confirmed

[fabiocos]

@prebello @zhenhu @kpedro88 do you have objections/comments or can we move this PR forward?

[lpernie]

Yes

[kpedro88]

+upgrade

[prebello]

+1

no objections.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1