Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal Geometry layer clipping tool #25284

Merged
merged 20 commits into from Nov 20, 2018
Merged

Conversation

Mourtz
Copy link
Contributor

@Mourtz Mourtz commented Nov 19, 2018

Depends on #25282

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mourtz (Alex Mourtziapis) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Core
Fireworks/Geometry
Fireworks/SimData

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Nov 19, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31738/console Started: 2018/11/19 18:13

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

@Mourtz this PR is claimed to depend on #25282 that has been closed. Could you please clarify?

@Mourtz
Copy link
Contributor Author

Mourtz commented Nov 20, 2018

@fabiocos Sorry I used the wrong word there, it was including that PR not depending on it.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7124ad8 into cms-sw:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants