Discard Beamspot fit results when d0-phi fit status is unknown

[sarafiorendi]

1. Invalidating d0-phi results when an empty reco::Beamspot object is returned due to the failing of the 1D gaussian fit to the track z0 distribution
2. When combining the d0-phi results with the PV fit results, only consider d0-phi fits with status > 0 as good.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25319/7345

[cmsbuild]

A new Pull Request was created by @sarafiorendi for master.

It involves the following packages:

RecoVertex/BeamSpotProducer

@perrotta, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @tocheng, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[lpernie]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31807/console Started: 2018/11/22 18:06

[cmsbuild]

+1
Tested at: 8a0556f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25319/31807/summary.html

[cmsbuild]

Comparison job queued.

[tocheng]

@fabiocos
This is to fix a NaN output of the offline beamspot.
We expect to merge it into the next patch release for heavy Ion data taking next week if possible.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25319/31807/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013111
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

type bugfix

[perrotta]

+1

• The fix does make sense, and may prevent returning NaN's from the offline beamspot parameters
• Jenkins tests pass, and standard workflows are unaffected

[fabiocos]

@lpernie @tocheng thank you for the clarification about the plan, the first step if getting it integrated into master without issues

[fabiocos]

@sarafiorendi was this for instance tested on some recent failing data?

[sarafiorendi]

Hi @fabiocos,

yes, I tested it on LS 19 of Run 326522.
The result from the PCL was:

Runnumber 326522
BeginTimeOfFit 2018.11.11 01:38:22 GMT 1541900302
EndTimeOfFit 2018.11.11 01:38:37 GMT 1541900317
LumiRange 19 - 19
Type 2
X0 0
Y0 0
Z0 1.46136
sigmaZ0 5.344
dxdz 0
dydz 0
BeamWidthX 0.0014138
BeamWidthY 0.000837015
Cov(0,j) 0 0 0 0 0 0 0
Cov(1,j) 0 0 0 0 0 0 0
Cov(2,j) 0 0 1.67888 0 0 0 0
Cov(3,j) 0 0 0 0.83689 0 0 0
Cov(4,j) 0 0 0 0 0 0 0
Cov(5,j) 0 0 0 0 0 0 0
Cov(6,j) 0 0 0 0 0 0 7.81293e-08
EmittanceX 0
EmittanceY 0
BetaStar 0

so, Type = 2 -> good fit, but with all-0 values from the d0-phi part.
After the fix I get

Runnumber 326522
BeginTimeOfFit 2018.11.11 01:38:22 GMT 1541900302
EndTimeOfFit 2018.11.11 01:38:37 GMT 1541900317
LumiRange 19 - 19
Type -1
X0 0
Y0 0
Z0 0
sigmaZ0 0
dxdz 0
dydz 0
BeamWidthX 0
BeamWidthY 0
Cov(0,j) 0 0 0 0 0 0 0
Cov(1,j) 0 0 0 0 0 0 0
Cov(2,j) 0 0 0 0 0 0 0
Cov(3,j) 0 0 0 0 0 0 0
Cov(4,j) 0 0 0 0 0 0 0
Cov(5,j) 0 0 0 0 0 0 0
Cov(6,j) 0 0 0 0 0 0 0
EmittanceX 0
EmittanceY 0
BetaStar 0

where the result is correctly marked as bad (type -1).

[fabiocos]

@tocheng @lpernie ping

[tocheng]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1