[Backport] Discard Beamspot fit results when d0-phi fit status is unknown

[sarafiorendi]

Backport of #25319

[cmsbuild]

A new Pull Request was created by @sarafiorendi for CMSSW_10_3_X.

It involves the following packages:

RecoVertex/BeamSpotProducer

@perrotta, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @tocheng, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Discard Beamspot fit results when d0-phi fit status is unknown #25319

[lpernie]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31806/console Started: 2018/11/22 18:06

[cmsbuild]

+1
Tested at: 978f698
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25320/31806/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25320/31806/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3181535
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3181336
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

type bugfix

[perrotta]

Is this extra accepted trigger path in RunJetHT2017FreMINIAOD wf 136p8311 depending on this fix?

[davidlange6]

note that this workflow doesn't rerun the HLT..

…

On Nov 23, 2018, at 10:43 AM, perrotta ***@***.***> wrote: Is this extra accepted trigger path in RunJetHT2017FreMINIAOD wf 136p8311 depending on this fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[perrotta]

Good point, thank you @davidlange6 : then I am puzzled...

[perrotta]

The issue causing the non-reproducible behaviour observed here in the path monitoring was traced in #25324 as caused by some missing initialization in the HcalNoiseSummary, and the fix is proposed by @slava77 with #25325 (104X), #25326 (102X), and #25327 (103X).
In particular this confirms that the non reproducibility observed is not due to this PR

[tocheng]

+1

[perrotta]

+1

• The fix prevents returning NaN's from the offline beamspot parameters
• Jenkins tests pass, and standard workflows are unaffected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1