[9_4_X] DeepDoubleCvL and DeepDoubleCvB tagger integration

[andrzejnovak]

Backport of #24918

Dependent on cms-data/RecoBTag-Combined#19

[cmsbuild]

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for CMSSW_9_4_X.

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/TensorFlow

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @hqucms, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from DeepDoubleCvL and DeepDoubleCvB tagger integration #24918

[andrzejnovak]

Updated with changes to requested in #25370

[andrzejnovak]

@slava77 can we run test on this now?

[perrotta]

@cmsbuild please test with cms-sw/cmsdist#4549

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4549
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32051/console

[cmsbuild]

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25371/32051/git-merge-result

[andrzejnovak]

@fabiocos Is there anything else holding this up?

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32439/console Started: 2019/01/07 17:21

[cmsbuild]

+1
Tested at: 8a281a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25371/32439/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4c9bf4c
462aaa7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25371/32439/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25371/32439/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25371/32439/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 101
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721230
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[smuzaffar]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25371/7866

• This PR adds an extra 48KB to repository

• Found files with invalid states:

  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDB_mass_independent.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c
  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDC_mass_independent.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c
  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDCvB.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c
  • RecoBTag/MXNet/test/test_deep_boosted_jet_cfg.py:
    • Deleted: 720031b
    • Added: a59c602, c3c264f
  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDC.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c
  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDB.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c
  • RecoBTag/TensorFlow/python/pfDeepDoubleBJetTags_cfi.py:
    • Added: 6027596
    • Deleted: e7f8610
  • RecoBTag/Combined/data/DeepDoubleX/94X/V01/DDCvB_mass_independent.pb:
    • Added: 720031b
    • Deleted: 7f04895, 8db949c

[fabiocos]

@smuzaffar thanks, I will squash the commits when merging in order to get rid of the unwanted data files (and the rest), there is not such a big review to be preserved

[andrzejnovak]

@slava77 @perrotta @fabiocos @ferencek When can we expect this to be included in a release? The taggers are supported by BTV and we'd like to have a stable rel to build commissioning and SF measurement against. The no change policy should be satisfied.

[slava77]

@andrzejnovak
this PR was merged on Jan 9.
There was a general push to move the analysis to 10_2_X.
This is the reason for no 9_4_X release so far (since 9_4_12 released on Nov 21).

[slava77]

BTW, there will likely be a new 94X for other purposes soon (fastsim fixes).
So, this should fit your needs, I guess.