Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Phase-1 tagger versions #19

Merged
merged 1 commit into from Nov 29, 2018
Merged

Conversation

andrzejnovak
Copy link
Contributor

Final model files for cms-sw/cmssw#24918

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4537

@mrodozov
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link

slava77 commented Nov 29, 2018

@mrodozov @smuzaffar
do we have a way already to test a PR to an external repo without merging it first?

If not, changes here look "OK" (no strange files added or no existing ones unexpectedly removed): in this case this PR can be merged and we proceed to the testing step with a cmsdist PR.

@smuzaffar
Copy link
Contributor

@slava77 , no not yet.

@mrodozov
Copy link
Contributor

@slava77 almost there

@mrodozov mrodozov merged commit 900c362 into cms-data:master Nov 29, 2018
mrodozov added a commit to cms-sw/cmsdist that referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants