MTD geometry: move topology parameters from PSet to xml, adapt the code #25417
Conversation
…gyMode wrt to the original clone of HCAL code
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25417/7465 |
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: CondFormats/GeometryObjects @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @ggovi, @pohsun, @kpedro88, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@pmeridian @casarsa FYI @lpernie @tocheng @ggovi for CondFormats I just have added the PMTDParameters to the list of tests |
|
please test |
|
The tests are being triggered in jenkins. |
| } else { | ||
| ptp.vpars_ = pars_; | ||
| } | ||
| std::list<std::string> mtdSubdet { "BTL", "ETL" }; |
There was a problem hiding this comment.
std::array is probably better than std::list
| } | ||
| std::list<std::string> mtdSubdet { "BTL", "ETL" }; | ||
| int subdet(0); | ||
| for( auto name : mtdSubdet ) |
There was a problem hiding this comment.
@kpedro88 yes, I agree it is preferable here
|
Comparison job queued. |
|
Pull request #25417 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+upgrade |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
MTD geometry: move topology parameters from PSet to xml, adapt the code
This PR follows #25352 , addressing some comments of @kpedro88 to #25063 about the propagation of mtdParameters through PSets. Now all parameters are moved from a PSet to xml files, as done for other detectors, and the MTDParametersFromDD class has been adapted accordingly.
Furthermore it addresses comments by @makortel to #25384 concerning the previous implementation of MTDTopologyMode, which was simply cloned from HCAL code. Now there is an enum Class and a function moving strings into values of this enum, both defined in a namespace MTDTopologyMode. The MTDTopologyAnalyzer class has been extended in order to dump both the original DetId built from DD (and in the MTDCommonData tests) and the information are reconstructed from the generic DetId by the MTD Topology. @lgray this class produces the output I ask you to cross check for consistency.